Checkstyle Results
The following document contains the results of
Checkstyle
.
Summary
| Files | Infos | Warnings | Errors |
| 116 | 0 | 0 | 3664 |
Files
org/astrogrid/AstroGridException.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
7
|
| Line has trailing spaces. |
8
|
| First sentence should end with a period. |
15
|
| First sentence should end with a period. |
21
|
| First sentence should end with a period. |
26
|
| 'message' hides a field. |
30
|
| First sentence should end with a period. |
34
|
| 'message' hides a field. |
40
|
| First sentence should end with a period. |
46
|
| First sentence should end with a period. |
54
|
org/astrogrid/Configurator.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line is longer than 80 characters. |
32
|
| Line is longer than 80 characters. |
33
|
| Line has trailing spaces. |
34
|
| Line is longer than 80 characters. |
37
|
| First sentence should end with a period. |
40
|
| Line is longer than 80 characters. |
42
|
| Line is longer than 80 characters. |
44
|
| First sentence should end with a period. |
45
|
| First sentence should end with a period. |
49
|
| First sentence should end with a period. |
52
|
| First sentence should end with a period. |
54
|
| First sentence should end with a period. |
58
|
| First sentence should end with a period. |
99
|
| First sentence should end with a period. |
180
|
| Line is longer than 80 characters. |
203
|
| First sentence should end with a period. |
211
|
| First sentence should end with a period. |
239
|
| First sentence should end with a period. |
249
|
| First sentence should end with a period. |
259
|
| First sentence should end with a period. |
264
|
| Line has trailing spaces. |
272
|
| Line has trailing spaces. |
273
|
| Line is longer than 80 characters. |
273
|
| Line is longer than 80 characters. |
274
|
| Line is longer than 80 characters. |
276
|
| Line is longer than 80 characters. |
290
|
| Line is longer than 80 characters. |
303
|
| Line is longer than 80 characters. |
323
|
| First sentence should end with a period. |
352
|
| First sentence should end with a period. |
367
|
| Line has trailing spaces. |
370
|
| First sentence should end with a period. |
374
|
| First sentence should end with a period. |
380
|
| First sentence should end with a period. |
385
|
| First sentence should end with a period. |
393
|
| First sentence should end with a period. |
402
|
| First sentence should end with a period. |
412
|
org/astrogrid/TemplateManager.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| ';' is preceded with whitespace. |
13
|
| ';' is preceded with whitespace. |
14
|
| ';' is preceded with whitespace. |
15
|
| ';' is preceded with whitespace. |
17
|
| Using the '.*' form of import should be avoided - org.jconfig.utils.*. |
19
|
| Using the '.*' form of import should be avoided - java.io.*. |
20
|
| ';' is preceded with whitespace. |
20
|
| First sentence should end with a period. |
23
|
| Class TemplateManager should be declared as final. |
32
|
| Missing a Javadoc comment. |
34
|
| ';' is preceded with whitespace. |
35
|
| Missing a Javadoc comment. |
37
|
| Line is longer than 80 characters. |
38
|
| Name 'ASTROGRIDERROR_UNABLE_TO_LOCATE_TEMPLATE' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
38
|
| ';' is preceded with whitespace. |
38
|
| Missing a Javadoc comment. |
40
|
| ';' is preceded with whitespace. |
41
|
| Line is longer than 80 characters. |
44
|
| Missing a Javadoc comment. |
44
|
| '{' is not preceded with whitespace. |
44
|
| Missing a Javadoc comment. |
47
|
| '{' is not followed by whitespace. |
47
|
| '}' is not preceded with whitespace. |
47
|
| Missing a Javadoc comment. |
50
|
| '(' is followed by whitespace. |
50
|
| Parameter subsystemAcronym should be final. |
50
|
| Parameter name should be final. |
50
|
| ')' is preceded with whitespace. |
50
|
| '(' is followed by whitespace. |
51
|
| ';' is preceded with whitespace. |
51
|
| ';' is preceded with whitespace. |
54
|
| ';' is preceded with whitespace. |
56
|
| 'cast' is not followed by whitespace. |
60
|
| '(' is followed by whitespace. |
60
|
| ')' is preceded with whitespace. |
60
|
| ';' is preceded with whitespace. |
60
|
| 'if' is not followed by whitespace. |
62
|
| '(' is followed by whitespace. |
62
|
| ')' is preceded with whitespace. |
62
|
| '(' is followed by whitespace. |
65
|
| ')' is preceded with whitespace. |
65
|
| ';' is preceded with whitespace. |
65
|
| Line is longer than 80 characters. |
68
|
| '(' is followed by whitespace. |
68
|
| '(' is followed by whitespace. |
68
|
| ')' is preceded with whitespace. |
68
|
| ')' is preceded with whitespace. |
68
|
| ';' is preceded with whitespace. |
68
|
| '(' is followed by whitespace. |
71
|
| '1024' is a magic number. |
71
|
| ')' is preceded with whitespace. |
71
|
| ';' is preceded with whitespace. |
71
|
| ';' is preceded with whitespace. |
73
|
| ';' is preceded with whitespace. |
75
|
| 'while' is not followed by whitespace. |
76
|
| '(' is followed by whitespace. |
76
|
| ')' is preceded with whitespace. |
76
|
| '{' is not preceded with whitespace. |
76
|
| '(' is followed by whitespace. |
77
|
| ')' is preceded with whitespace. |
77
|
| ';' is preceded with whitespace. |
77
|
| ';' is preceded with whitespace. |
78
|
| ';' is preceded with whitespace. |
81
|
| '(' is followed by whitespace. |
82
|
| ')' is preceded with whitespace. |
82
|
| ';' is preceded with whitespace. |
82
|
| '}' should be on the same line. |
86
|
| '(' is followed by whitespace. |
87
|
| ')' is preceded with whitespace. |
87
|
| Line is longer than 80 characters. |
90
|
| '(' is followed by whitespace. |
90
|
| Line is longer than 80 characters. |
92
|
| '(' is followed by whitespace. |
92
|
| ')' is preceded with whitespace. |
92
|
| ')' is preceded with whitespace. |
93
|
| ';' is preceded with whitespace. |
93
|
| '(' is followed by whitespace. |
94
|
| ')' is preceded with whitespace. |
94
|
| ';' is preceded with whitespace. |
94
|
| '}' should be on the same line. |
96
|
| 'if' construct must use '{}'s. |
98
|
| Line is longer than 80 characters. |
98
|
| 'if' is not followed by whitespace. |
98
|
| '(' is followed by whitespace. |
98
|
| ')' is preceded with whitespace. |
98
|
| 'try' is not followed by whitespace. |
98
|
| '{' is not preceded with whitespace. |
98
|
| 'catch' is not followed by whitespace. |
98
|
| '(' is followed by whitespace. |
98
|
| ')' is preceded with whitespace. |
98
|
| '{' is not preceded with whitespace. |
98
|
| Empty statement. |
98
|
| '(' is followed by whitespace. |
99
|
| ';' is preceded with whitespace. |
99
|
| ';' is preceded with whitespace. |
102
|
org/astrogrid/common/bean/BaseBean.java
| Error | Line |
| File does not end with a newline. |
0
|
org/astrogrid/common/bean/BaseBean.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
7
|
| Line has trailing spaces. |
8
|
| Line is longer than 80 characters. |
24
|
| First sentence should end with a period. |
28
|
| Line has trailing spaces. |
29
|
| Line has trailing spaces. |
34
|
| Missing a Javadoc comment. |
35
|
| First sentence should end with a period. |
36
|
| Line is longer than 80 characters. |
37
|
| Line is longer than 80 characters. |
38
|
| Expected an @return tag. |
39
|
| Line has trailing spaces. |
44
|
| Line has trailing spaces. |
45
|
| Line is longer than 80 characters. |
45
|
| ',' is not followed by whitespace. |
45
|
| Line has trailing spaces. |
48
|
| First sentence should end with a period. |
49
|
| Parameter fn should be final. |
50
|
| Expected @param tag for 'fn'. |
50
|
| Line is longer than 80 characters. |
51
|
| 'cast' is not followed by whitespace. |
51
|
| First sentence should end with a period. |
53
|
| Line is longer than 80 characters. |
53
|
| Line has trailing spaces. |
54
|
| Parameter xpath should be final. |
58
|
| First sentence should end with a period. |
61
|
| Line is longer than 80 characters. |
61
|
| Line has trailing spaces. |
62
|
| Parameter xpath should be final. |
66
|
| Line has trailing spaces. |
69
|
| Line has trailing spaces. |
71
|
| Line is longer than 80 characters. |
72
|
| Parameter target should be final. |
76
|
| 'cxt' hides a field. |
78
|
| ',' is not followed by whitespace. |
79
|
| Line has trailing spaces. |
81
|
| Line has trailing spaces. |
84
|
| Avoid inline conditionals. |
84
|
| First sentence should end with a period. |
87
|
| Utility classes should not have a public or default constructor. |
89
|
| Line has trailing spaces. |
94
|
| Expected an @return tag. |
95
|
| Parameter ctxt should be final. |
95
|
| Expected @param tag for 'ctxt'. |
95
|
| Line is longer than 80 characters. |
97
|
| Line has trailing spaces. |
100
|
| Line has trailing spaces. |
101
|
| Line is longer than 80 characters. |
101
|
| Line has trailing spaces. |
102
|
| Expected an @return tag. |
104
|
| Parameter ctxt should be final. |
104
|
| Expected @param tag for 'ctxt'. |
104
|
| Line has trailing spaces. |
116
|
| Line has trailing spaces. |
118
|
| Line has trailing spaces. |
122
|
| Line has trailing spaces. |
133
|
org/astrogrid/common/creator/Creator.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
14
|
| Method 'newInstance' is not designed for extension - needs to be abstract, final or empty. |
16
|
| Missing a Javadoc comment. |
16
|
| Parameter className should be final. |
16
|
| Line has trailing spaces. |
19
|
| Line is longer than 80 characters. |
20
|
| Method 'newInstance' is not designed for extension - needs to be abstract, final or empty. |
20
|
| Missing a Javadoc comment. |
20
|
| Parameter className should be final. |
20
|
| Parameter parameters should be final. |
20
|
| Line has trailing spaces. |
22
|
| '}' should be on the same line. |
30
|
| 'catch' is not followed by whitespace. |
31
|
| '}' should be on the same line. |
38
|
| 'catch' is not followed by whitespace. |
39
|
| '}' should be on the same line. |
41
|
| 'catch' is not followed by whitespace. |
42
|
| '}' should be on the same line. |
44
|
| 'catch' is not followed by whitespace. |
45
|
| '}' should be on the same line. |
48
|
| 'catch' is not followed by whitespace. |
49
|
| '}' should be on the same line. |
51
|
| 'catch' is not followed by whitespace. |
52
|
| Line has trailing spaces. |
55
|
| Line has trailing spaces. |
58
|
| Missing a Javadoc comment. |
59
|
| Parameter parameters should be final. |
59
|
| Line has trailing spaces. |
61
|
| 'if' is not followed by whitespace. |
62
|
| 'for' is not followed by whitespace. |
64
|
| Line has trailing spaces. |
67
|
| Line has trailing spaces. |
68
|
| Line has trailing spaces. |
71
|
| Missing a Javadoc comment. |
72
|
| Parameter classes should be final. |
72
|
| Line has trailing spaces. |
74
|
| 'if' is not followed by whitespace. |
75
|
| 'for' is not followed by whitespace. |
77
|
| Line has trailing spaces. |
80
|
| Line has trailing spaces. |
81
|
| Line has trailing spaces. |
84
|
| Missing a Javadoc comment. |
85
|
| Parameter clazz should be final. |
85
|
| Line has trailing spaces. |
87
|
| Line has trailing spaces. |
89
|
| 'if' is not followed by whitespace. |
93
|
| 'if' is not followed by whitespace. |
96
|
| '{' is not preceded with whitespace. |
96
|
| '}' should be on the same line. |
100
|
| 'catch' is not followed by whitespace. |
101
|
| '}' should be on the same line. |
103
|
| 'catch' is not followed by whitespace. |
104
|
| Line has trailing spaces. |
107
|
org/astrogrid/common/creator/CreatorException.java
| Error | Line |
| File does not end with a newline. |
0
|
org/astrogrid/common/creator/CreatorException.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
3
|
| Parameter message should be final. |
11
|
| Expected @param tag for 'message'. |
11
|
| Parameter message should be final. |
19
|
| Expected @param tag for 'message'. |
19
|
| Parameter cause should be final. |
19
|
| Expected @param tag for 'cause'. |
19
|
| Parameter cause should be final. |
26
|
| Expected @param tag for 'cause'. |
26
|
org/astrogrid/common/creator/InstanceCreator.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
14
|
| Line has trailing spaces. |
15
|
| Missing a Javadoc comment. |
17
|
| Method 'getInstance' is not designed for extension - needs to be abstract, final or empty. |
19
|
| Missing a Javadoc comment. |
19
|
| Parameter className should be final. |
19
|
| Line is longer than 80 characters. |
23
|
| Method 'getInstance' is not designed for extension - needs to be abstract, final or empty. |
23
|
| Missing a Javadoc comment. |
23
|
| Parameter className should be final. |
23
|
| Parameter parameters should be final. |
23
|
| Line has trailing spaces. |
26
|
| Line is longer than 80 characters. |
27
|
| Method 'getInstance' is not designed for extension - needs to be abstract, final or empty. |
27
|
| Missing a Javadoc comment. |
27
|
| Parameter className should be final. |
27
|
| Parameter methodName should be final. |
27
|
| Parameter parameters should be final. |
27
|
| Line has trailing spaces. |
29
|
| 'if' is not followed by whitespace. |
30
|
| Line has trailing spaces. |
33
|
| Line has trailing spaces. |
36
|
| Line has trailing spaces. |
39
|
| '}' should be on the same line. |
42
|
| 'catch' is not followed by whitespace. |
43
|
| Line has trailing spaces. |
47
|
| 'if' is not followed by whitespace. |
49
|
| '}' should be on the same line. |
52
|
| 'catch' is not followed by whitespace. |
53
|
| '}' should be on the same line. |
55
|
| 'catch' is not followed by whitespace. |
56
|
| '}' should be on the same line. |
60
|
| 'catch' is not followed by whitespace. |
61
|
| '}' should be on the same line. |
63
|
| 'catch' is not followed by whitespace. |
64
|
| Line has trailing spaces. |
67
|
| Missing a Javadoc comment. |
71
|
| Parameter parameters should be final. |
71
|
| Line has trailing spaces. |
73
|
| 'if' is not followed by whitespace. |
74
|
| 'for' is not followed by whitespace. |
76
|
| Line has trailing spaces. |
79
|
| Line has trailing spaces. |
80
|
| Missing a Javadoc comment. |
84
|
| Parameter classes should be final. |
84
|
| Line has trailing spaces. |
86
|
| 'if' is not followed by whitespace. |
87
|
| 'for' is not followed by whitespace. |
89
|
| Line has trailing spaces. |
92
|
| Line has trailing spaces. |
93
|
| Line has trailing spaces. |
96
|
| Missing a Javadoc comment. |
97
|
| Parameter clazz should be final. |
97
|
| Line has trailing spaces. |
99
|
| Line has trailing spaces. |
101
|
| 'if' is not followed by whitespace. |
105
|
| 'if' is not followed by whitespace. |
108
|
| '{' is not preceded with whitespace. |
108
|
| '}' should be on the same line. |
112
|
| 'catch' is not followed by whitespace. |
113
|
| '}' should be on the same line. |
115
|
| 'catch' is not followed by whitespace. |
116
|
| Line has trailing spaces. |
119
|
org/astrogrid/common/creator/InstanceCreatorException.java
| Error | Line |
| File does not end with a newline. |
0
|
org/astrogrid/common/creator/InstanceCreatorException.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
3
|
| Parameter message should be final. |
11
|
| Expected @param tag for 'message'. |
11
|
| Parameter message should be final. |
19
|
| Expected @param tag for 'message'. |
19
|
| Parameter cause should be final. |
19
|
| Expected @param tag for 'cause'. |
19
|
| Parameter cause should be final. |
26
|
| Expected @param tag for 'cause'. |
26
|
org/astrogrid/common/creator/package.html
| Error | Line |
| Missing package documentation file. | 0 |
org/astrogrid/common/delegate/AbstractDelegate.java
| Error | Line |
| File does not end with a newline. |
0
|
org/astrogrid/common/delegate/AbstractDelegate.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
7
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
18
|
| Line is longer than 80 characters. |
24
|
| Missing a Javadoc comment. |
24
|
| Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
24
|
| Missing a Javadoc comment. |
25
|
| Missing a Javadoc comment. |
27
|
| Variable 'targetEndPoint' must be private and have accessor methods. |
27
|
| Missing a Javadoc comment. |
29
|
| Variable 'timeout' must be private and have accessor methods. |
29
|
| Method 'setTargetEndPoint' is not designed for extension - needs to be abstract, final or empty. |
31
|
| Missing a Javadoc comment. |
31
|
| Parameter targetEndPoint should be final. |
31
|
| 'targetEndPoint' hides a field. |
31
|
| Line contains a tab character. |
32
|
| Method 'getTargetEndPoint' is not designed for extension - needs to be abstract, final or empty. |
35
|
| Missing a Javadoc comment. |
35
|
| Line contains a tab character. |
36
|
| Method 'setTimeout' is not designed for extension - needs to be abstract, final or empty. |
39
|
| Missing a Javadoc comment. |
39
|
| Parameter timeout should be final. |
39
|
| 'timeout' hides a field. |
39
|
| Line contains a tab character. |
40
|
| Method 'getTimeout' is not designed for extension - needs to be abstract, final or empty. |
43
|
| Missing a Javadoc comment. |
43
|
| Line contains a tab character. |
44
|
| Line has trailing spaces. |
46
|
| First sentence should end with a period. |
47
|
| Expected an @return tag. |
48
|
| Parameter endpoint should be final. |
48
|
| Expected @param tag for 'endpoint'. |
48
|
| Line is longer than 80 characters. |
50
|
| Line has trailing spaces. |
58
|
| Line has trailing spaces. |
61
|
| Line has trailing spaces. |
83
|
org/astrogrid/common/delegate/Delegate.java
| Error | Line |
| File does not end with a newline. |
0
|
org/astrogrid/common/delegate/Delegate.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
7
|
| Line has trailing spaces. |
8
|
| First sentence should end with a period. |
17
|
| Redundant 'public' modifier. |
18
|
| 'static' modifier out of order with the JLS suggestions. |
18
|
| First sentence should end with a period. |
20
|
| Line has trailing spaces. |
20
|
| Expected an @return tag. |
23
|
| Redundant 'public' modifier. |
23
|
| First sentence should end with a period. |
24
|
| Redundant 'public' modifier. |
25
|
| Expected @param tag for 'timeout'. |
25
|
| First sentence should end with a period. |
26
|
| Expected an @return tag. |
27
|
| Redundant 'public' modifier. |
27
|
| Line has trailing spaces. |
29
|
| Line has trailing spaces. |
63
|
org/astrogrid/common/j2ee/EnvEntriesTabulator.java
| Error | Line |
| File does not end with a newline. |
0
|
org/astrogrid/common/j2ee/EnvEntriesTabulator.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Comment matches to-do format 'TODO:'. |
35
|
| '{' is not followed by whitespace. |
50
|
| '}' is not preceded with whitespace. |
50
|
| Method 'setContext' is not designed for extension - needs to be abstract, final or empty. |
62
|
| Parameter context should be final. |
62
|
| 'context' hides a field. |
62
|
| Method 'getTable' is not designed for extension - needs to be abstract, final or empty. |
72
|
| '+' should be on a new line. |
76
|
| '}' should be on the same line. |
106
|
org/astrogrid/common/j2ee/environment/EnvEntry.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line is longer than 80 characters. |
13
|
| First sentence should end with a period. |
35
|
| Expected an @return tag. |
47
|
| Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
47
|
| Method 'setName' is not designed for extension - needs to be abstract, final or empty. |
54
|
| Parameter name should be final. |
54
|
| 'name' hides a field. |
54
|
| Expected @param tag for 'name'. |
54
|
| Expected an @return tag. |
66
|
| Method 'getType' is not designed for extension - needs to be abstract, final or empty. |
66
|
| Method 'setType' is not designed for extension - needs to be abstract, final or empty. |
73
|
| Parameter type should be final. |
73
|
| 'type' hides a field. |
73
|
| Expected @param tag for 'type'. |
73
|
| Line is longer than 80 characters. |
78
|
| Expected an @return tag. |
89
|
| Method 'getDefaultValue' is not designed for extension - needs to be abstract, final or empty. |
89
|
| Method 'setDefaultValue' is not designed for extension - needs to be abstract, final or empty. |
96
|
| Parameter value should be final. |
96
|
| Expected @param tag for 'value'. |
96
|
| Expected an @return tag. |
112
|
| Method 'getOperationalValue' is not designed for extension - needs to be abstract, final or empty. |
112
|
| 'cast' is not followed by whitespace. |
116
|
| '}' should be on the same line. |
118
|
| Method 'setOperationalValue' is not designed for extension - needs to be abstract, final or empty. |
127
|
| Parameter value should be final. |
127
|
| Expected @param tag for 'value'. |
127
|
| Expected an @return tag. |
143
|
| Method 'getReplacementValue' is not designed for extension - needs to be abstract, final or empty. |
143
|
| '}' should be on the same line. |
146
|
| Method 'setReplacementValue' is not designed for extension - needs to be abstract, final or empty. |
155
|
| Parameter value should be final. |
155
|
| Expected @param tag for 'value'. |
155
|
| Expected an @return tag. |
170
|
| Method 'getDescription' is not designed for extension - needs to be abstract, final or empty. |
170
|
| Method 'setDescription' is not designed for extension - needs to be abstract, final or empty. |
181
|
| Parameter description should be final. |
181
|
| 'description' hides a field. |
181
|
| Expected @param tag for 'description'. |
181
|
org/astrogrid/common/j2ee/environment/Environment.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
48
|
| First sentence should end with a period. |
50
|
| '{' is not followed by whitespace. |
51
|
| '}' is not preceded with whitespace. |
51
|
| Expected an @return tag. |
61
|
| Method 'getContextPath' is not designed for extension - needs to be abstract, final or empty. |
61
|
| Method 'setContextPath' is not designed for extension - needs to be abstract, final or empty. |
69
|
| Parameter path should be final. |
69
|
| Expected @param tag for 'path'. |
69
|
| Expected an @return tag. |
82
|
| Method 'getTomcatContextFileName' is not designed for extension - needs to be abstract, final or empty. |
82
|
| Expected an @return tag. |
94
|
| Method 'getEnvEntry' is not designed for extension - needs to be abstract, final or empty. |
94
|
| Parameter index should be final. |
94
|
| Expected @param tag for 'index'. |
94
|
| Expected an @return tag. |
101
|
| Method 'getEnvEntry' is not designed for extension - needs to be abstract, final or empty. |
101
|
| Method 'setDeploymentDescriptor' is not designed for extension - needs to be abstract, final or empty. |
110
|
| Parameter webDotXmlUri should be final. |
110
|
| Expected @param tag for 'webDotXmlUri'. |
110
|
| Expected @throws tag for 'Exception'. |
110
|
| Line has trailing spaces. |
112
|
| Line has trailing spaces. |
123
|
| Parameter envEntryNode should be final. |
139
|
| Expected @throws tag for 'Exception'. |
139
|
| '}' should be on the same line. |
152
|
| '}' should be on the same line. |
155
|
| '}' should be on the same line. |
158
|
| Parameter node should be final. |
175
|
| '}' should be on the same line. |
195
|
| Line has trailing spaces. |
200
|
| Line has trailing spaces. |
209
|
| Method 'resolveEntity' is not designed for extension - needs to be abstract, final or empty. |
220
|
| Parameter publicId should be final. |
220
|
| Parameter systemId should be final. |
220
|
| Line is longer than 80 characters. |
222
|
| '}' should be on the same line. |
226
|
| Line is longer than 80 characters. |
227
|
| '}' should be on the same line. |
231
|
| Line has trailing spaces. |
238
|
org/astrogrid/common/j2ee/environment/EnvironmentServlet.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
39
|
| Missing a Javadoc comment. |
40
|
| Line has trailing spaces. |
41
|
| Line has trailing spaces. |
47
|
| First sentence should end with a period. |
54
|
| Method 'init' is not designed for extension - needs to be abstract, final or empty. |
59
|
| Missing a Javadoc comment. |
59
|
| Line has trailing spaces. |
68
|
| Line is longer than 80 characters. |
74
|
| '-' is not preceded with whitespace. |
74
|
| '-' is not followed by whitespace. |
74
|
| '}' should be on the same line. |
77
|
| Line is longer than 80 characters. |
84
|
| Method 'doGet' is not designed for extension - needs to be abstract, final or empty. |
84
|
| Missing a Javadoc comment. |
84
|
| Parameter request should be final. |
84
|
| Parameter response should be final. |
84
|
| Line is longer than 80 characters. |
88
|
| Method 'doPost' is not designed for extension - needs to be abstract, final or empty. |
88
|
| Missing a Javadoc comment. |
88
|
| Parameter request should be final. |
88
|
| Parameter response should be final. |
88
|
| Line is longer than 80 characters. |
90
|
| Line is longer than 80 characters. |
91
|
| 'cast' is not followed by whitespace. |
95
|
| Line is longer than 80 characters. |
101
|
| '}' should be on the same line. |
103
|
| Missing a Javadoc comment. |
109
|
| Parameter name should be final. |
109
|
| Parameter value should be final. |
109
|
org/astrogrid/common/j2ee/package.html
| Error | Line |
| Missing package documentation file. | 0 |
org/astrogrid/common/namegen/CommonsLoggingFacade.java
| Error | Line |
| File does not end with a newline. |
0
|
org/astrogrid/common/namegen/CommonsLoggingFacade.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
7
|
| Line has trailing spaces. |
8
|
| Line is longer than 80 characters. |
18
|
| Missing a Javadoc comment. |
21
|
| Parameter logger should be final. |
21
|
| 'logger' hides a field. |
21
|
| Missing a Javadoc comment. |
24
|
| Variable 'logger' must be private and have accessor methods. |
24
|
| Line has trailing spaces. |
25
|
| Line is longer than 80 characters. |
27
|
| Method 'createLogger' is not designed for extension - needs to be abstract, final or empty. |
29
|
| Parameter arg0 should be final. |
29
|
| Line is longer than 80 characters. |
34
|
| Method 'logInfo' is not designed for extension - needs to be abstract, final or empty. |
36
|
| Parameter arg0 should be final. |
36
|
| Line is longer than 80 characters. |
41
|
| Method 'logFine' is not designed for extension - needs to be abstract, final or empty. |
43
|
| Parameter arg0 should be final. |
43
|
| Method 'isFineEnabled' is not designed for extension - needs to be abstract, final or empty. |
50
|
| Line is longer than 80 characters. |
55
|
| Method 'logFiner' is not designed for extension - needs to be abstract, final or empty. |
57
|
| Parameter arg0 should be final. |
57
|
| Method 'isFinerEnabled' is not designed for extension - needs to be abstract, final or empty. |
64
|
| Line is longer than 80 characters. |
69
|
| Method 'logFinest' is not designed for extension - needs to be abstract, final or empty. |
71
|
| Parameter arg0 should be final. |
71
|
| Method 'isFinestEnabled' is not designed for extension - needs to be abstract, final or empty. |
78
|
| Line is longer than 80 characters. |
83
|
| Method 'logWarning' is not designed for extension - needs to be abstract, final or empty. |
85
|
| Parameter arg0 should be final. |
85
|
| Line is longer than 80 characters. |
90
|
| Method 'logWarning' is not designed for extension - needs to be abstract, final or empty. |
92
|
| Parameter arg0 should be final. |
92
|
| Parameter arg1 should be final. |
92
|
| ',' is not followed by whitespace. |
93
|
| Line is longer than 80 characters. |
97
|
| Method 'logSevere' is not designed for extension - needs to be abstract, final or empty. |
99
|
| Parameter arg0 should be final. |
99
|
| Line is longer than 80 characters. |
104
|
| Method 'logSevere' is not designed for extension - needs to be abstract, final or empty. |
106
|
| Parameter arg0 should be final. |
106
|
| Parameter arg1 should be final. |
106
|
| ',' is not followed by whitespace. |
107
|
| Line has trailing spaces. |
111
|
| Line has trailing spaces. |
131
|
org/astrogrid/common/namegen/FileNameGen.java
| Error | Line |
| File does not end with a newline. |
0
|
org/astrogrid/common/namegen/FileNameGen.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
7
|
| Line has trailing spaces. |
8
|
| Line has trailing spaces. |
21
|
| Line is longer than 80 characters. |
21
|
| First sentence should end with a period. |
26
|
| Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
29
|
| Missing a Javadoc comment. |
31
|
| Variable 'seq' must be private and have accessor methods. |
31
|
| Missing a Javadoc comment. |
32
|
| Variable 'sequenceName' must be private and have accessor methods. |
32
|
| First sentence should end with a period. |
33
|
| Line has trailing spaces. |
35
|
| Line is longer than 80 characters. |
37
|
| Parameter workingDir should be final. |
37
|
| Expected @param tag for 'workingDir'. |
37
|
| Parameter sequenceName should be final. |
37
|
| 'sequenceName' hides a field. |
37
|
| Expected @param tag for 'sequenceName'. |
37
|
| Expected @throws tag for 'ResourceManagerException'. |
37
|
| Expected @throws tag for 'IllegalArgumentException'. |
37
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
37
|
| Line is longer than 80 characters. |
41
|
| ',' is not followed by whitespace. |
41
|
| ',' is not followed by whitespace. |
44
|
| '100L' is a magic number. |
44
|
| Line is longer than 80 characters. |
52
|
| Redundant 'final' modifier. |
52
|
| Parameter workingDir should be final. |
52
|
| Expected @param tag for 'workingDir'. |
52
|
| Expected @throws tag for 'IllegalArgumentException'. |
52
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
52
|
| '!' is followed by whitespace. |
53
|
| Line has trailing spaces. |
55
|
| Line is longer than 80 characters. |
58
|
| Line has trailing spaces. |
60
|
| '!' is followed by whitespace. |
67
|
| Line is longer than 80 characters. |
68
|
| Line has trailing spaces. |
73
|
| Line has trailing spaces. |
77
|
| Method 'next' is not designed for extension - needs to be abstract, final or empty. |
85
|
| ',' is not followed by whitespace. |
86
|
| Line has trailing spaces. |
89
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
90
|
| Missing a Javadoc comment. |
90
|
| Line has trailing spaces. |
101
|
| Line has trailing spaces. |
124
|
org/astrogrid/common/namegen/InMemoryNameGen.java
| Error | Line |
| File does not end with a newline. |
0
|
org/astrogrid/common/namegen/InMemoryNameGen.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
7
|
| Line has trailing spaces. |
8
|
| First sentence should end with a period. |
22
|
| Line has trailing spaces. |
23
|
| Line has trailing spaces. |
31
|
| Method 'next' is not designed for extension - needs to be abstract, final or empty. |
36
|
| Missing a Javadoc comment. |
36
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
45
|
| Missing a Javadoc comment. |
45
|
| Line has trailing spaces. |
54
|
| Line has trailing spaces. |
77
|
org/astrogrid/common/namegen/NameGen.java
| Error | Line |
| File does not end with a newline. |
0
|
org/astrogrid/common/namegen/NameGen.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
7
|
| Line has trailing spaces. |
8
|
| First sentence should end with a period. |
14
|
| Expected an @return tag. |
20
|
| Expected @throws tag for 'Exception'. |
20
|
| Line has trailing spaces. |
21
|
| Line has trailing spaces. |
25
|
| Line has trailing spaces. |
45
|
org/astrogrid/common/registry/InstanceRegistry.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
17
|
| Missing a Javadoc comment. |
18
|
| Line has trailing spaces. |
19
|
| Missing a Javadoc comment. |
20
|
| Parameter registry should be final. |
20
|
| 'registry' hides a field. |
20
|
| Line has trailing spaces. |
23
|
| Line is longer than 80 characters. |
24
|
| Missing a Javadoc comment. |
24
|
| Parameter filename should be final. |
24
|
| Redundant throws: 'FileNotFoundException' is subclass of 'IOException'. |
24
|
| Missing a Javadoc comment. |
28
|
| Parameter inStream should be final. |
28
|
| Missing a Javadoc comment. |
33
|
| Parameter registry should be final. |
33
|
| 'registry' hides a field. |
33
|
| Parameter creator should be final. |
33
|
| 'creator' hides a field. |
33
|
| Line has trailing spaces. |
37
|
| Method 'getInstance' is not designed for extension - needs to be abstract, final or empty. |
38
|
| Missing a Javadoc comment. |
38
|
| Parameter property should be final. |
38
|
| Line has trailing spaces. |
41
|
| Line is longer than 80 characters. |
42
|
| Method 'getInstance' is not designed for extension - needs to be abstract, final or empty. |
42
|
| Missing a Javadoc comment. |
42
|
| Parameter property should be final. |
42
|
| Parameter methodName should be final. |
42
|
| Parameter parameters should be final. |
42
|
| Line has trailing spaces. |
44
|
| 'if' is not followed by whitespace. |
46
|
| Line has trailing spaces. |
49
|
| Line has trailing spaces. |
52
|
| Line is longer than 80 characters. |
53
|
| Method 'getInstance' is not designed for extension - needs to be abstract, final or empty. |
53
|
| Missing a Javadoc comment. |
53
|
| Parameter property should be final. |
53
|
| Parameter clazz should be final. |
53
|
| Redundant throws: 'ClassCastException' is unchecked exception. |
53
|
| Line is longer than 80 characters. |
57
|
| Method 'getInstance' is not designed for extension - needs to be abstract, final or empty. |
57
|
| Missing a Javadoc comment. |
57
|
| Parameter property should be final. |
57
|
| Parameter methodName should be final. |
57
|
| Parameter parameters should be final. |
57
|
| Parameter clazz should be final. |
57
|
| Redundant throws: 'ClassCastException' is unchecked exception. |
57
|
| Line has trailing spaces. |
59
|
| 'if' is not followed by whitespace. |
60
|
| Line has trailing spaces. |
63
|
| Line has trailing spaces. |
66
|
org/astrogrid/common/registry/Registry.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
17
|
| Missing a Javadoc comment. |
18
|
| Line has trailing spaces. |
19
|
| Missing a Javadoc comment. |
20
|
| Parameter registry should be final. |
20
|
| 'registry' hides a field. |
20
|
| Line has trailing spaces. |
23
|
| Missing a Javadoc comment. |
24
|
| Parameter filename should be final. |
24
|
| Redundant throws: 'FileNotFoundException' is subclass of 'IOException'. |
24
|
| Missing a Javadoc comment. |
28
|
| Parameter inStream should be final. |
28
|
| Missing a Javadoc comment. |
33
|
| Parameter registry should be final. |
33
|
| 'registry' hides a field. |
33
|
| Parameter creator should be final. |
33
|
| 'creator' hides a field. |
33
|
| Line has trailing spaces. |
37
|
| Method 'newInstance' is not designed for extension - needs to be abstract, final or empty. |
38
|
| Missing a Javadoc comment. |
38
|
| Parameter property should be final. |
38
|
| Line has trailing spaces. |
41
|
| Line is longer than 80 characters. |
42
|
| Method 'newInstance' is not designed for extension - needs to be abstract, final or empty. |
42
|
| Missing a Javadoc comment. |
42
|
| Parameter property should be final. |
42
|
| Parameter parameters should be final. |
42
|
| Line has trailing spaces. |
44
|
| 'if' is not followed by whitespace. |
46
|
| Line has trailing spaces. |
49
|
| Line has trailing spaces. |
52
|
| Line is longer than 80 characters. |
53
|
| Method 'newInstance' is not designed for extension - needs to be abstract, final or empty. |
53
|
| Missing a Javadoc comment. |
53
|
| Parameter property should be final. |
53
|
| Parameter clazz should be final. |
53
|
| Redundant throws: 'ClassCastException' is unchecked exception. |
53
|
| Line is longer than 80 characters. |
57
|
| Method 'newInstance' is not designed for extension - needs to be abstract, final or empty. |
57
|
| Missing a Javadoc comment. |
57
|
| Parameter property should be final. |
57
|
| Parameter parameters should be final. |
57
|
| Parameter clazz should be final. |
57
|
| Redundant throws: 'ClassCastException' is unchecked exception. |
57
|
| Line has trailing spaces. |
59
|
| 'if' is not followed by whitespace. |
60
|
| Line has trailing spaces. |
63
|
| Line has trailing spaces. |
66
|
org/astrogrid/common/registry/package.html
| Error | Line |
| Missing package documentation file. | 0 |
org/astrogrid/community/Account.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line is longer than 80 characters. |
30
|
| Line is longer than 80 characters. |
32
|
| Line is longer than 80 characters. |
35
|
| Line is longer than 80 characters. |
37
|
| Line is longer than 80 characters. |
45
|
| Line is longer than 80 characters. |
46
|
| Line is longer than 80 characters. |
48
|
| Missing a Javadoc comment. |
57
|
| Missing a Javadoc comment. |
58
|
| Missing a Javadoc comment. |
59
|
| Line has trailing spaces. |
61
|
| Line is longer than 80 characters. |
62
|
| Missing a Javadoc comment. |
62
|
| 'static' modifier out of order with the JLS suggestions. |
62
|
| ',' is not followed by whitespace. |
62
|
| ',' is not followed by whitespace. |
62
|
| First sentence should end with a period. |
64
|
| '{' is not preceded with whitespace. |
69
|
| ',' is not followed by whitespace. |
70
|
| Parameter anIndividual should be final. |
77
|
| Expected @param tag for 'anIndividual'. |
77
|
| Parameter aCommunity should be final. |
77
|
| Expected @param tag for 'aCommunity'. |
77
|
| Parameter aToken should be final. |
77
|
| Expected @param tag for 'aToken'. |
77
|
| '{' should be on the previous line. |
78
|
| Line is longer than 80 characters. |
79
|
| '>' is not preceded with whitespace. |
79
|
| '>' is not followed by whitespace. |
79
|
| Line is longer than 80 characters. |
80
|
| '>' is not preceded with whitespace. |
80
|
| '>' is not followed by whitespace. |
80
|
| Line has trailing spaces. |
83
|
| Line has trailing spaces. |
88
|
| Line has trailing spaces. |
89
|
| Parameter snippet should be final. |
94
|
| '{' should be on the previous line. |
95
|
| Line is longer than 80 characters. |
96
|
| ',' is not followed by whitespace. |
96
|
| Line is longer than 80 characters. |
97
|
| '+' is not preceded with whitespace. |
97
|
| '+' is not followed by whitespace. |
97
|
| Line has trailing spaces. |
100
|
| First sentence should end with a period. |
101
|
| Expected an @return tag. |
102
|
| Method 'getIndividual' is not designed for extension - needs to be abstract, final or empty. |
102
|
| First sentence should end with a period. |
106
|
| Line is longer than 80 characters. |
106
|
| Expected an @return tag. |
108
|
| Method 'getAstrogridId' is not designed for extension - needs to be abstract, final or empty. |
108
|
| '+' is not preceded with whitespace. |
109
|
| '+' is not followed by whitespace. |
109
|
| '+' is not preceded with whitespace. |
109
|
| '+' is not followed by whitespace. |
109
|
| Line has trailing spaces. |
111
|
| First sentence should end with a period. |
112
|
| Line is longer than 80 characters. |
112
|
| Expected an @return tag. |
114
|
| Method 'getIvorn' is not designed for extension - needs to be abstract, final or empty. |
114
|
| '+' is not preceded with whitespace. |
115
|
| '+' is not followed by whitespace. |
115
|
| '+' is not preceded with whitespace. |
115
|
| '+' is not followed by whitespace. |
115
|
| '+' is not preceded with whitespace. |
115
|
| '+' is not followed by whitespace. |
115
|
| First sentence should end with a period. |
118
|
| Expected an @return tag. |
119
|
| Method 'getCommunity' is not designed for extension - needs to be abstract, final or empty. |
119
|
| First sentence should end with a period. |
123
|
| Expected an @return tag. |
125
|
| Method 'getToken' is not designed for extension - needs to be abstract, final or empty. |
125
|
| Expected an @return tag. |
134
|
| Definition of 'equals()' without corresponding definition of 'hashCode()'. |
134
|
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
134
|
| Parameter user should be final. |
134
|
| Expected @param tag for 'user'. |
134
|
| '{' should be on the previous line. |
135
|
| First sentence should end with a period. |
139
|
| Expected an @return tag. |
142
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
142
|
| '{' should be on the previous line. |
143
|
| Line has trailing spaces. |
146
|
| Method 'toSnippet' is not designed for extension - needs to be abstract, final or empty. |
151
|
| '{' should be on the previous line. |
152
|
| Line has trailing spaces. |
155
|
| First sentence should end with a period. |
156
|
| Expected an @return tag. |
160
|
| Method 'toUser' is not designed for extension - needs to be abstract, final or empty. |
160
|
| '{' should be on the previous line. |
161
|
| Line has trailing spaces. |
164
|
org/astrogrid/community/User.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
20
|
| Line is longer than 80 characters. |
21
|
| Line has trailing spaces. |
22
|
| Line is longer than 80 characters. |
22
|
| Line has trailing spaces. |
23
|
| Line is longer than 80 characters. |
24
|
| Line is longer than 80 characters. |
25
|
| Missing a Javadoc comment. |
32
|
| Variable 'account' must be private and have accessor methods. |
32
|
| Missing a Javadoc comment. |
33
|
| Variable 'group' must be private and have accessor methods. |
33
|
| Missing a Javadoc comment. |
34
|
| Variable 'token' must be private and have accessor methods. |
34
|
| Line has trailing spaces. |
35
|
| Line is longer than 80 characters. |
36
|
| Missing a Javadoc comment. |
36
|
| 'static' modifier out of order with the JLS suggestions. |
36
|
| ',' is not followed by whitespace. |
36
|
| ',' is not followed by whitespace. |
36
|
| First sentence should end with a period. |
38
|
| '{' is not preceded with whitespace. |
40
|
| ',' is not followed by whitespace. |
41
|
| Parameter givenAccount should be final. |
51
|
| Parameter givenGroup should be final. |
51
|
| Parameter givenToken should be final. |
51
|
| '{' should be on the previous line. |
52
|
| Line has trailing spaces. |
54
|
| Line is longer than 80 characters. |
55
|
| Line has trailing spaces. |
57
|
| Line has trailing spaces. |
60
|
| Parameter userId should be final. |
67
|
| Parameter community should be final. |
67
|
| Parameter group should be final. |
67
|
| 'group' hides a field. |
67
|
| Parameter token should be final. |
67
|
| 'token' hides a field. |
67
|
| '{' should be on the previous line. |
68
|
| '+' is not preceded with whitespace. |
69
|
| '+' is not followed by whitespace. |
69
|
| '+' is not preceded with whitespace. |
69
|
| '+' is not followed by whitespace. |
69
|
| Line has trailing spaces. |
73
|
| Parameter snippet should be final. |
78
|
| '{' should be on the previous line. |
79
|
| Line is longer than 80 characters. |
80
|
| ',' is not followed by whitespace. |
80
|
| ',' is not followed by whitespace. |
80
|
| Line has trailing spaces. |
82
|
| Expected an @return tag. |
86
|
| Method 'getAccount' is not designed for extension - needs to be abstract, final or empty. |
86
|
| Expected an @return tag. |
93
|
| Method 'getGroup' is not designed for extension - needs to be abstract, final or empty. |
93
|
| Expected an @return tag. |
100
|
| Method 'getToken' is not designed for extension - needs to be abstract, final or empty. |
100
|
| Method 'setAccount' is not designed for extension - needs to be abstract, final or empty. |
107
|
| Parameter string should be final. |
107
|
| Expected @param tag for 'string'. |
107
|
| Method 'setGroup' is not designed for extension - needs to be abstract, final or empty. |
114
|
| Parameter string should be final. |
114
|
| Expected @param tag for 'string'. |
114
|
| Method 'setToken' is not designed for extension - needs to be abstract, final or empty. |
121
|
| Parameter string should be final. |
121
|
| Expected @param tag for 'string'. |
121
|
| First sentence should end with a period. |
126
|
| Expected an @return tag. |
130
|
| Definition of 'equals()' without corresponding definition of 'hashCode()'. |
130
|
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
130
|
| Parameter user should be final. |
130
|
| Expected @param tag for 'user'. |
130
|
| '{' should be on the previous line. |
131
|
| Line is longer than 80 characters. |
132
|
| First sentence should end with a period. |
135
|
| Expected an @return tag. |
138
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
138
|
| '{' should be on the previous line. |
139
|
| Line has trailing spaces. |
142
|
| Method 'toSnippet' is not designed for extension - needs to be abstract, final or empty. |
147
|
| '{' should be on the previous line. |
148
|
| Line has trailing spaces. |
151
|
| First sentence should end with a period. |
152
|
| Line is longer than 80 characters. |
154
|
| Method 'getCommunity' is not designed for extension - needs to be abstract, final or empty. |
156
|
| '{' should be on the previous line. |
157
|
| 'if' is not followed by whitespace. |
158
|
| '{' should be on the previous line. |
159
|
| 'if' is not followed by whitespace. |
161
|
| '=' is not preceded with whitespace. |
161
|
| '!=' is not preceded with whitespace. |
161
|
| '{' should be on the previous line. |
162
|
| '+' is not preceded with whitespace. |
163
|
| '+' is not followed by whitespace. |
163
|
| Expected an @return tag. |
172
|
| Method 'getUserId' is not designed for extension - needs to be abstract, final or empty. |
172
|
| '{' should be on the previous line. |
173
|
| 'if' is not followed by whitespace. |
174
|
| '!=' is not preceded with whitespace. |
174
|
| '!=' is not followed by whitespace. |
174
|
| '{' should be on the previous line. |
175
|
| 'if' is not followed by whitespace. |
177
|
| '=' is not preceded with whitespace. |
177
|
| '!=' is not preceded with whitespace. |
177
|
| '{' should be on the previous line. |
178
|
| '}' should be on the same line. |
180
|
| '{' should be on the previous line. |
182
|
| Line is longer than 80 characters. |
204
|
| Line is longer than 80 characters. |
205
|
| Line is longer than 80 characters. |
220
|
org/astrogrid/community/common/util/CommunityMessage.java
| Error | Line |
| File does not end with a newline. |
0
|
org/astrogrid/community/common/util/CommunityMessage.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line is longer than 80 characters. |
5
|
| Utility classes should not have a public or default constructor. |
11
|
| Line has trailing spaces. |
12
|
| Expected an @return tag. |
20
|
| Line is longer than 80 characters. |
20
|
| Parameter token should be final. |
20
|
| Expected @param tag for 'token'. |
20
|
| ',' is not followed by whitespace. |
20
|
| Parameter account should be final. |
20
|
| Expected @param tag for 'account'. |
20
|
| ',' is not followed by whitespace. |
20
|
| Parameter credential should be final. |
20
|
| Expected @param tag for 'credential'. |
20
|
| '100' is a magic number. |
21
|
| Line has trailing spaces. |
37
|
| Line has trailing spaces. |
38
|
| Missing a Javadoc comment. |
39
|
| Parameter xmlMessage should be final. |
39
|
| 'if' is not followed by whitespace. |
42
|
| Line is longer than 80 characters. |
43
|
| ',' is not followed by whitespace. |
43
|
| Missing a Javadoc comment. |
48
|
| Parameter xmlMessage should be final. |
48
|
| 'if' is not followed by whitespace. |
51
|
| Line is longer than 80 characters. |
52
|
| ',' is not followed by whitespace. |
52
|
| Missing a Javadoc comment. |
57
|
| Parameter xmlMessage should be final. |
57
|
| 'if' is not followed by whitespace. |
60
|
| Line is longer than 80 characters. |
61
|
| ',' is not followed by whitespace. |
61
|
| Line has trailing spaces. |
64
|
org/astrogrid/community/common/util/package.html
| Error | Line |
| Missing package documentation file. | 0 |
org/astrogrid/component/ComponentManager.java
| Error | Line |
| File does not end with a newline. |
0
|
org/astrogrid/component/ComponentManager.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
7
|
| Line has trailing spaces. |
8
|
| Line is longer than 80 characters. |
20
|
| '{' is not preceded with whitespace. |
24
|
| Line has trailing spaces. |
25
|
| First sentence should end with a period. |
26
|
| Line has trailing spaces. |
28
|
| Line is longer than 80 characters. |
29
|
| Expected an @return tag. |
30
|
| Redundant 'public' modifier. |
30
|
| First sentence should end with a period. |
31
|
| Expected an @return tag. |
32
|
| Redundant 'public' modifier. |
32
|
| First sentence should end with a period. |
33
|
| Line has trailing spaces. |
33
|
| Line is longer than 80 characters. |
33
|
| Line is longer than 80 characters. |
35
|
| Line is longer than 80 characters. |
36
|
| Expected an @return tag. |
38
|
| Redundant 'public' modifier. |
38
|
| First sentence should end with a period. |
39
|
| Expected an @return tag. |
40
|
| Redundant 'public' modifier. |
40
|
| Line has trailing spaces. |
44
|
| Line is longer than 80 characters. |
47
|
| Line has trailing spaces. |
48
|
org/astrogrid/component/ComponentManagerException.java
| Error | Line |
| File does not end with a newline. |
0
|
org/astrogrid/component/ComponentManagerException.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
7
|
| Line has trailing spaces. |
8
|
| Line is longer than 80 characters. |
13
|
| Line is longer than 80 characters. |
14
|
| First sentence should end with a period. |
19
|
| Line has trailing spaces. |
20
|
| First sentence should end with a period. |
25
|
| Parameter message should be final. |
28
|
| Expected @param tag for 'message'. |
28
|
| First sentence should end with a period. |
31
|
| Parameter cause should be final. |
34
|
| Expected @param tag for 'cause'. |
34
|
| First sentence should end with a period. |
37
|
| Parameter message should be final. |
41
|
| Expected @param tag for 'message'. |
41
|
| Parameter cause should be final. |
41
|
| Expected @param tag for 'cause'. |
41
|
| Line has trailing spaces. |
47
|
| Line is longer than 80 characters. |
50
|
| Line has trailing spaces. |
57
|
org/astrogrid/component/EmptyComponentManager.java
| Error | Line |
| File does not end with a newline. |
0
|
org/astrogrid/component/EmptyComponentManager.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
7
|
| Line has trailing spaces. |
8
|
| '{' is not preceded with whitespace. |
31
|
| Line has trailing spaces. |
33
|
| Line is longer than 80 characters. |
33
|
| Missing a Javadoc comment. |
33
|
| Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
33
|
| First sentence should end with a period. |
34
|
| Line has trailing spaces. |
35
|
| First sentence should end with a period. |
40
|
| Variable 'pico' must be private and have accessor methods. |
41
|
| Method 'informationHTML' is not designed for extension - needs to be abstract, final or empty. |
42
|
| Missing a Javadoc comment. |
42
|
| Line has trailing spaces. |
43
|
| Line is longer than 80 characters. |
47
|
| ';' is followed by whitespace. |
47
|
| 'cast' is not followed by whitespace. |
50
|
| Line has trailing spaces. |
52
|
| Line is longer than 80 characters. |
52
|
| Method 'information' is not designed for extension - needs to be abstract, final or empty. |
60
|
| Missing a Javadoc comment. |
60
|
| Line has trailing spaces. |
61
|
| Line is longer than 80 characters. |
66
|
| ';' is followed by whitespace. |
66
|
| 'cast' is not followed by whitespace. |
69
|
| Line has trailing spaces. |
71
|
| Line has trailing spaces. |
72
|
| Method 'getSuite' is not designed for extension - needs to be abstract, final or empty. |
79
|
| Missing a Javadoc comment. |
79
|
| Line has trailing spaces. |
80
|
| Line has trailing spaces. |
81
|
| Line is longer than 80 characters. |
83
|
| ';' is followed by whitespace. |
83
|
| 'cast' is not followed by whitespace. |
86
|
| Method 'getContainer' is not designed for extension - needs to be abstract, final or empty. |
98
|
| Method 'start' is not designed for extension - needs to be abstract, final or empty. |
104
|
| Method 'stop' is not designed for extension - needs to be abstract, final or empty. |
111
|
| Line has trailing spaces. |
114
|
| Line has trailing spaces. |
118
|
| Line is longer than 80 characters. |
121
|
| Line is longer than 80 characters. |
127
|
| Line has trailing spaces. |
128
|
org/astrogrid/component/descriptor/ComponentDescriptor.java
| Error | Line |
| File does not end with a newline. |
0
|
org/astrogrid/component/descriptor/ComponentDescriptor.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
7
|
| Line has trailing spaces. |
8
|
| Line is longer than 80 characters. |
17
|
| First sentence should end with a period. |
23
|
| Expected an @return tag. |
24
|
| First sentence should end with a period. |
25
|
| Line is longer than 80 characters. |
25
|
| Expected an @return tag. |
26
|
| Line is longer than 80 characters. |
27
|
| Expected an @return tag. |
30
|
| ';' is preceded with whitespace. |
30
|
| Line has trailing spaces. |
31
|
| Line has trailing spaces. |
35
|
| Line is longer than 80 characters. |
38
|
| Line has trailing spaces. |
51
|
org/astrogrid/component/descriptor/SimpleComponentDescriptor.java
| Error | Line |
| File does not end with a newline. |
0
|
org/astrogrid/component/descriptor/SimpleComponentDescriptor.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line has trailing spaces. |
6
|
| Line has trailing spaces. |
7
|
| Line has trailing spaces. |
8
|
| First sentence should end with a period. |
15
|
| Missing a Javadoc comment. |
20
|
| '{' is not preceded with whitespace. |
20
|
| First sentence should end with a period. |
22
|
| Line has trailing spaces. |
23
|
| Parameter name should be final. |
25
|
| 'name' hides a field. |
25
|
| Expected @param tag for 'name'. |
25
|
| ',' is not followed by whitespace. |
25
|
| Parameter description should be final. |
25
|
| 'description' hides a field. |
25
|
| Expected @param tag for 'description'. |
25
|
| ',' is not followed by whitespace. |
26
|
| ',' is not followed by whitespace. |
26
|
| Line has trailing spaces. |
28
|
| Missing a Javadoc comment. |
29
|
| Parameter name should be final. |
29
|
| 'name' hides a field. |
29
|
| ',' is not followed by whitespace. |
29
|
| Parameter description should be final. |
29
|
| 'description' hides a field. |
29
|
| ',' is not followed by whitespace. |
29
|
| Parameter test should be final. |
29
|
| 'test' hides a field. |
29
|
| Missing a Javadoc comment. |
34
|
| Variable 'name' must be private and have accessor methods. |
34
|
| Missing a Javadoc comment. |
35
|
| Variable 'description' must be private and have accessor methods. |
35
|
| Missing a Javadoc comment. |
36
|
| Variable 'test' must be private and have accessor methods. |
36
|
| Method 'getName' is not designed for extension - needs to be abstract, final or empty. |
40
|
| Method 'getDescription' is not designed for extension - needs to be abstract, final or empty. |
46
|
| Line is longer than 80 characters. |
50
|
| Method 'getInstallationTest' is not designed for extension - needs to be abstract, final or empty. |
52
|
| Line has trailing spaces. |
58
|
| Line is longer than 80 characters. |
61
|
| Line has trailing spaces. |
74
|
org/astrogrid/component/package.html
| Error | Line |
| Missing package documentation file. | 0 |
org/astrogrid/config/Config.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| First sentence should end with a period. |
40
|
| Variable 'log' must be private and have accessor methods. |
41
|
| First sentence should end with a period. |
44
|
| Expected an @return tag. |
49
|
| Line is longer than 80 characters. |
49
|
| Parameter key should be final. |
49
|
| Expected @param tag for 'key'. |
49
|
| Expected @throws tag for 'PropertyNotFoundException'. |
49
|
| Redundant throws: 'PropertyNotFoundException' is unchecked exception. |
49
|
| Parameter key should be final. |
53
|
| Expected @param tag for 'key'. |
53
|
| Parameter value should be final. |
53
|
| Expected @param tag for 'value'. |
53
|
| Line has trailing spaces. |
54
|
| Line is longer than 80 characters. |
55
|
| Expected an @return tag. |
57
|
| Line is longer than 80 characters. |
57
|
| Parameter key should be final. |
57
|
| Expected @param tag for 'key'. |
57
|
| Expected @throws tag for 'PropertyNotFoundException'. |
57
|
| Redundant throws: 'PropertyNotFoundException' is unchecked exception. |
57
|
| First sentence should end with a period. |
59
|
| Parameter key should be final. |
60
|
| Expected @param tag for 'key'. |
60
|
| Parameter values should be final. |
60
|
| Expected @param tag for 'values'. |
60
|
| Line has trailing spaces. |
61
|
| Line has trailing spaces. |
64
|
| First sentence should end with a period. |
65
|
| Parameter url should be final. |
66
|
| Expected @param tag for 'url'. |
66
|
| Expected @throws tag for 'IOException'. |
66
|
| Parameter out should be final. |
70
|
| Expected @param tag for 'out'. |
70
|
| Line has trailing spaces. |
71
|
| First sentence should end with a period. |
72
|
| Expected an @return tag. |
73
|
| Line has trailing spaces. |
74
|
| First sentence should end with a period. |
75
|
| Method 'addLoadedFrom' is not designed for extension - needs to be abstract, final or empty. |
78
|
| Parameter s should be final. |
78
|
| Expected @param tag for 's'. |
78
|
| '+' is not preceded with whitespace. |
82
|
| '+' is not followed by whitespace. |
82
|
| First sentence should end with a period. |
86
|
| Expected an @return tag. |
89
|
| Method 'loadedFrom' is not designed for extension - needs to be abstract, final or empty. |
89
|
| Line has trailing spaces. |
95
|
| Expected an @return tag. |
99
|
| Method 'getProperty' is not designed for extension - needs to be abstract, final or empty. |
99
|
| Parameter key should be final. |
99
|
| Expected @param tag for 'key'. |
99
|
| Parameter defaultValue should be final. |
99
|
| Expected @param tag for 'defaultValue'. |
99
|
| Line has trailing spaces. |
100
|
| '}' should be on the same line. |
103
|
| Line has trailing spaces. |
107
|
| First sentence should end with a period. |
110
|
| Expected an @return tag. |
113
|
| Method 'getString' is not designed for extension - needs to be abstract, final or empty. |
113
|
| Parameter key should be final. |
113
|
| Expected @param tag for 'key'. |
113
|
| Line has trailing spaces. |
116
|
| First sentence should end with a period. |
117
|
| Expected an @return tag. |
120
|
| Method 'getString' is not designed for extension - needs to be abstract, final or empty. |
120
|
| Parameter key should be final. |
120
|
| Expected @param tag for 'key'. |
120
|
| Parameter defaultValue should be final. |
120
|
| Expected @param tag for 'defaultValue'. |
120
|
| Line is longer than 80 characters. |
121
|
| Expected an @return tag. |
133
|
| Method 'getUrl' is not designed for extension - needs to be abstract, final or empty. |
133
|
| Parameter key should be final. |
133
|
| Expected @param tag for 'key'. |
133
|
| Line has trailing spaces. |
134
|
| '}' should be on the same line. |
137
|
| Line is longer than 80 characters. |
139
|
| '+' is not preceded with whitespace. |
139
|
| '+' is not followed by whitespace. |
139
|
| '+' is not preceded with whitespace. |
139
|
| '+' is not followed by whitespace. |
139
|
| '+' is not preceded with whitespace. |
139
|
| '+' is not followed by whitespace. |
139
|
| '+' is not preceded with whitespace. |
139
|
| '+' is not followed by whitespace. |
139
|
| Line has trailing spaces. |
142
|
| Expected an @return tag. |
147
|
| Method 'getUrl' is not designed for extension - needs to be abstract, final or empty. |
147
|
| Parameter key should be final. |
147
|
| Expected @param tag for 'key'. |
147
|
| Parameter defaultValue should be final. |
147
|
| Expected @param tag for 'defaultValue'. |
147
|
| Line has trailing spaces. |
148
|
| '}' should be on the same line. |
151
|
| Line is longer than 80 characters. |
158
|
| Expected an @return tag. |
161
|
| Method 'getInt' is not designed for extension - needs to be abstract, final or empty. |
161
|
| Parameter key should be final. |
161
|
| Expected @param tag for 'key'. |
161
|
| Line has trailing spaces. |
162
|
| '}' should be on the same line. |
165
|
| Line is longer than 80 characters. |
167
|
| '+' is not preceded with whitespace. |
167
|
| '+' is not followed by whitespace. |
167
|
| '+' is not preceded with whitespace. |
167
|
| '+' is not followed by whitespace. |
167
|
| '+' is not preceded with whitespace. |
167
|
| '+' is not followed by whitespace. |
167
|
| '+' is not preceded with whitespace. |
167
|
| '+' is not followed by whitespace. |
167
|
| Line has trailing spaces. |
170
|
| Line is longer than 80 characters. |
172
|
| Expected an @return tag. |
175
|
| Method 'getInt' is not designed for extension - needs to be abstract, final or empty. |
175
|
| Parameter key should be final. |
175
|
| Expected @param tag for 'key'. |
175
|
| Parameter defaultValue should be final. |
175
|
| Expected @param tag for 'defaultValue'. |
175
|
| Line has trailing spaces. |
176
|
| '}' should be on the same line. |
179
|
| Line has trailing spaces. |
184
|
| Expected an @return tag. |
188
|
| Method 'getBoolean' is not designed for extension - needs to be abstract, final or empty. |
188
|
| Parameter key should be final. |
188
|
| Expected @param tag for 'key'. |
188
|
| Parameter defaultValue should be final. |
188
|
| Expected @param tag for 'defaultValue'. |
188
|
| Line has trailing spaces. |
189
|
| '}' should be on the same line. |
192
|
| Line has trailing spaces. |
197
|
| Expected an @return tag. |
201
|
| Method 'getBoolean' is not designed for extension - needs to be abstract, final or empty. |
201
|
| Parameter key should be final. |
201
|
| Expected @param tag for 'key'. |
201
|
| Expected an @return tag. |
211
|
| Method 'getDom' is not designed for extension - needs to be abstract, final or empty. |
211
|
| Parameter key should be final. |
211
|
| Expected @param tag for 'key'. |
211
|
| Line has trailing spaces. |
214
|
| Expected an @return tag. |
220
|
| Method 'getDom' is not designed for extension - needs to be abstract, final or empty. |
220
|
| Parameter key should be final. |
220
|
| Expected @param tag for 'key'. |
220
|
| Parameter defaultDom should be final. |
220
|
| Expected @param tag for 'defaultDom'. |
220
|
| '}' should be on the same line. |
223
|
| Line has trailing spaces. |
227
|
| Expected an @return tag. |
235
|
| Method 'getDom' is not designed for extension - needs to be abstract, final or empty. |
235
|
| Parameter key should be final. |
235
|
| Expected @param tag for 'key'. |
235
|
| Parameter defaultUrl should be final. |
235
|
| Expected @param tag for 'defaultUrl'. |
235
|
| '}' should be on the same line. |
238
|
| '+' is not preceded with whitespace. |
240
|
| '+' is not followed by whitespace. |
240
|
| '+' is not preceded with whitespace. |
240
|
| '+' is not followed by whitespace. |
240
|
| Line has trailing spaces. |
242
|
| Expected an @return tag. |
247
|
| Parameter key should be final. |
247
|
| Expected @param tag for 'key'. |
247
|
| Parameter source should be final. |
247
|
| Expected @param tag for 'source'. |
247
|
| '}' should be on the same line. |
250
|
| Line is longer than 80 characters. |
252
|
| '+' is not preceded with whitespace. |
252
|
| '+' is not followed by whitespace. |
252
|
| '+' is not preceded with whitespace. |
252
|
| '+' is not followed by whitespace. |
252
|
| '+' is not preceded with whitespace. |
252
|
| '+' is not followed by whitespace. |
252
|
| '+' is not preceded with whitespace. |
252
|
| '+' is not followed by whitespace. |
252
|
| '}' should be on the same line. |
253
|
| Line is longer than 80 characters. |
255
|
| '}' should be on the same line. |
256
|
| Line is longer than 80 characters. |
258
|
| '+' is not preceded with whitespace. |
258
|
| '+' is not followed by whitespace. |
258
|
| '+' is not preceded with whitespace. |
258
|
| '+' is not followed by whitespace. |
258
|
| '+' is not preceded with whitespace. |
258
|
| '+' is not followed by whitespace. |
258
|
| '+' is not preceded with whitespace. |
258
|
| '+' is not followed by whitespace. |
258
|
| Line is longer than 80 characters. |
262
|
| Line is longer than 80 characters. |
263
|
| Line is longer than 80 characters. |
269
|
| Expected an @return tag. |
278
|
| Parameter givenFilename should be final. |
278
|
| Expected @param tag for 'givenFilename'. |
278
|
| Expected @throws tag for 'IOException'. |
278
|
| Line has trailing spaces. |
279
|
| '+' is not preceded with whitespace. |
288
|
| '+' is not followed by whitespace. |
288
|
| '+' is not preceded with whitespace. |
288
|
| '+' is not followed by whitespace. |
288
|
| Line has trailing spaces. |
290
|
| '}' should be on the same line. |
297
|
| '{' should be on the previous line. |
299
|
| Line has trailing spaces. |
302
|
| '}' should be on the same line. |
305
|
| Line is longer than 80 characters. |
312
|
| '+' is not preceded with whitespace. |
312
|
| '+' is not followed by whitespace. |
312
|
| Expected an @return tag. |
321
|
| Parameter givenSource should be final. |
321
|
| Expected @param tag for 'givenSource'. |
321
|
| Line has trailing spaces. |
322
|
| Line has trailing spaces. |
324
|
| '>' is not preceded with whitespace. |
325
|
| '>' is not followed by whitespace. |
325
|
| 'if' construct must use '{}'s. |
328
|
| Line is longer than 80 characters. |
328
|
| '==' is not preceded with whitespace. |
328
|
| '==' is not followed by whitespace. |
328
|
| '+' is not preceded with whitespace. |
328
|
| '+' is not followed by whitespace. |
328
|
| '+' is not preceded with whitespace. |
328
|
| '+' is not followed by whitespace. |
328
|
| Line has trailing spaces. |
329
|
| '+' is not preceded with whitespace. |
330
|
| '+' is not followed by whitespace. |
330
|
| ',' is not followed by whitespace. |
330
|
| Line has trailing spaces. |
332
|
| Line has trailing spaces. |
338
|
| 'if' construct must use '{}'s. |
339
|
| Line is longer than 80 characters. |
339
|
| '+' is not preceded with whitespace. |
339
|
| '+' is not followed by whitespace. |
339
|
| '+' is not preceded with whitespace. |
339
|
| '+' is not followed by whitespace. |
339
|
| '+' is not preceded with whitespace. |
339
|
| '+' is not followed by whitespace. |
339
|
| Line has trailing spaces. |
340
|
| '+' is not preceded with whitespace. |
341
|
| '+' is not preceded with whitespace. |
341
|
| '+' is not followed by whitespace. |
341
|
| Line has trailing spaces. |
343
|
| Line has trailin
|