Checkstyle Results
The following document contains the results of
Checkstyle
.
Summary
| Files | Infos | Warnings | Errors |
| 13 | 0 | 0 | 960 |
Files
org/astrogrid/cfg/ConfigException.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line is longer than 80 characters. |
7
|
| Line has trailing spaces. |
22
|
| Missing a Javadoc comment. |
23
|
| Parameter msg should be final. |
23
|
| Parameter th should be final. |
23
|
| Line has trailing spaces. |
26
|
| Missing a Javadoc comment. |
27
|
| Parameter msg should be final. |
27
|
| Line has trailing spaces. |
30
|
org/astrogrid/cfg/ConfigFactory.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line is longer than 80 characters. |
19
|
| Utility classes should not have a public or default constructor. |
27
|
| '{' should be on the previous line. |
28
|
| First sentence should end with a period. |
29
|
| Name 'configs' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
30
|
| Line has trailing spaces. |
31
|
| First sentence should end with a period. |
32
|
| Line has trailing spaces. |
34
|
| Expected an @return tag. |
40
|
| Parameter id should be final. |
40
|
| '{' should be on the previous line. |
41
|
| Line has trailing spaces. |
43
|
| First sentence should end with a period. |
52
|
| Expected an @return tag. |
53
|
| Parameter id should be final. |
53
|
| Expected @param tag for 'id'. |
53
|
| Line has trailing spaces. |
56
|
| Line has trailing spaces. |
57
|
| Line is longer than 80 characters. |
58
|
| Line is longer than 80 characters. |
60
|
| Line is longer than 80 characters. |
64
|
| Expected an @return tag. |
69
|
| Expected an @return tag. |
77
|
| Line is longer than 80 characters. |
77
|
| Parameter context should be final. |
77
|
| Expected @param tag for 'context'. |
77
|
| Expected @throws tag for 'IOException'. |
77
|
| Line has trailing spaces. |
80
|
org/astrogrid/cfg/ConfigReader.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Redundant import from the same package - org.astrogrid.cfg.ConfigException. |
20
|
| First sentence should end with a period. |
38
|
| Variable 'log' must be private and have accessor methods. |
39
|
| First sentence should end with a period. |
42
|
| Expected an @return tag. |
47
|
| Line is longer than 80 characters. |
47
|
| Parameter key should be final. |
47
|
| Expected @param tag for 'key'. |
47
|
| Expected @throws tag for 'PropertyNotFoundException'. |
47
|
| Redundant throws: 'PropertyNotFoundException' is unchecked exception. |
47
|
| Parameter key should be final. |
50
|
| Expected @param tag for 'key'. |
50
|
| Parameter value should be final. |
50
|
| Expected @param tag for 'value'. |
50
|
| Line has trailing spaces. |
51
|
| Line is longer than 80 characters. |
52
|
| Expected an @return tag. |
54
|
| Line is longer than 80 characters. |
54
|
| Parameter key should be final. |
54
|
| Expected @param tag for 'key'. |
54
|
| Expected @throws tag for 'PropertyNotFoundException'. |
54
|
| Redundant throws: 'PropertyNotFoundException' is unchecked exception. |
54
|
| First sentence should end with a period. |
56
|
| Parameter key should be final. |
57
|
| Expected @param tag for 'key'. |
57
|
| Parameter values should be final. |
57
|
| Expected @param tag for 'values'. |
57
|
| Line has trailing spaces. |
58
|
| First sentence should end with a period. |
59
|
| Parameter url should be final. |
60
|
| Expected @param tag for 'url'. |
60
|
| Expected @throws tag for 'IOException'. |
60
|
| Parameter out should be final. |
64
|
| Expected @param tag for 'out'. |
64
|
| Line has trailing spaces. |
65
|
| First sentence should end with a period. |
66
|
| Expected an @return tag. |
67
|
| Line has trailing spaces. |
68
|
| First sentence should end with a period. |
69
|
| Method 'addLoadedFrom' is not designed for extension - needs to be abstract, final or empty. |
72
|
| Parameter s should be final. |
72
|
| Expected @param tag for 's'. |
72
|
| '+' is not preceded with whitespace. |
76
|
| '+' is not followed by whitespace. |
76
|
| First sentence should end with a period. |
80
|
| Expected an @return tag. |
83
|
| Method 'loadedFrom' is not designed for extension - needs to be abstract, final or empty. |
83
|
| Line has trailing spaces. |
89
|
| Line has trailing spaces. |
90
|
| Expected an @return tag. |
93
|
| Method 'getProperty' is not designed for extension - needs to be abstract, final or empty. |
93
|
| Parameter key should be final. |
93
|
| Expected @param tag for 'key'. |
93
|
| Parameter defaultValue should be final. |
93
|
| Expected @param tag for 'defaultValue'. |
93
|
| Line has trailing spaces. |
94
|
| '}' should be on the same line. |
97
|
| Line has trailing spaces. |
101
|
| First sentence should end with a period. |
104
|
| Expected an @return tag. |
107
|
| Method 'getString' is not designed for extension - needs to be abstract, final or empty. |
107
|
| Parameter key should be final. |
107
|
| Expected @param tag for 'key'. |
107
|
| Line has trailing spaces. |
110
|
| Expected an @return tag. |
116
|
| Method 'formKeyValue' is not designed for extension - needs to be abstract, final or empty. |
116
|
| Parameter key should be final. |
116
|
| Expected @param tag for 'key'. |
116
|
| Parameter value should be final. |
116
|
| Expected @param tag for 'value'. |
116
|
| '+' is not preceded with whitespace. |
118
|
| '+' is not followed by whitespace. |
118
|
| '+' is not preceded with whitespace. |
118
|
| '+' is not followed by whitespace. |
118
|
| '+' is not preceded with whitespace. |
120
|
| '+' is not followed by whitespace. |
120
|
| '+' is not preceded with whitespace. |
120
|
| '+' is not followed by whitespace. |
120
|
| '+' is not preceded with whitespace. |
120
|
| '+' is not followed by whitespace. |
120
|
| Line has trailing spaces. |
123
|
| First sentence should end with a period. |
125
|
| Expected an @return tag. |
128
|
| Method 'getString' is not designed for extension - needs to be abstract, final or empty. |
128
|
| Parameter key should be final. |
128
|
| Expected @param tag for 'key'. |
128
|
| Parameter defaultValue should be final. |
128
|
| Expected @param tag for 'defaultValue'. |
128
|
| Line is longer than 80 characters. |
129
|
| Expected an @return tag. |
141
|
| Method 'getUrl' is not designed for extension - needs to be abstract, final or empty. |
141
|
| Parameter key should be final. |
141
|
| Expected @param tag for 'key'. |
141
|
| Line has trailing spaces. |
142
|
| '}' should be on the same line. |
145
|
| Line is longer than 80 characters. |
147
|
| '+' is not preceded with whitespace. |
147
|
| '+' is not followed by whitespace. |
147
|
| '+' is not preceded with whitespace. |
147
|
| '+' is not followed by whitespace. |
147
|
| '+' is not preceded with whitespace. |
147
|
| '+' is not followed by whitespace. |
147
|
| '+' is not preceded with whitespace. |
147
|
| '+' is not followed by whitespace. |
147
|
| Line has trailing spaces. |
150
|
| Expected an @return tag. |
155
|
| Method 'getUrl' is not designed for extension - needs to be abstract, final or empty. |
155
|
| Parameter key should be final. |
155
|
| Expected @param tag for 'key'. |
155
|
| Parameter defaultValue should be final. |
155
|
| Expected @param tag for 'defaultValue'. |
155
|
| Line has trailing spaces. |
156
|
| '}' should be on the same line. |
159
|
| Line is longer than 80 characters. |
166
|
| Expected an @return tag. |
169
|
| Method 'getInt' is not designed for extension - needs to be abstract, final or empty. |
169
|
| Parameter key should be final. |
169
|
| Expected @param tag for 'key'. |
169
|
| Line has trailing spaces. |
170
|
| '}' should be on the same line. |
173
|
| Line is longer than 80 characters. |
175
|
| '+' is not preceded with whitespace. |
175
|
| '+' is not followed by whitespace. |
175
|
| '+' is not preceded with whitespace. |
175
|
| '+' is not followed by whitespace. |
175
|
| '+' is not preceded with whitespace. |
175
|
| '+' is not followed by whitespace. |
175
|
| '+' is not preceded with whitespace. |
175
|
| '+' is not followed by whitespace. |
175
|
| Line has trailing spaces. |
178
|
| Line is longer than 80 characters. |
180
|
| Expected an @return tag. |
183
|
| Method 'getInt' is not designed for extension - needs to be abstract, final or empty. |
183
|
| Parameter key should be final. |
183
|
| Expected @param tag for 'key'. |
183
|
| Parameter defaultValue should be final. |
183
|
| Expected @param tag for 'defaultValue'. |
183
|
| Line has trailing spaces. |
184
|
| '}' should be on the same line. |
187
|
| Line has trailing spaces. |
192
|
| Expected an @return tag. |
196
|
| Method 'getBoolean' is not designed for extension - needs to be abstract, final or empty. |
196
|
| Parameter key should be final. |
196
|
| Expected @param tag for 'key'. |
196
|
| Parameter defaultValue should be final. |
196
|
| Expected @param tag for 'defaultValue'. |
196
|
| Line has trailing spaces. |
197
|
| '}' should be on the same line. |
200
|
| Line has trailing spaces. |
205
|
| Expected an @return tag. |
209
|
| Method 'getBoolean' is not designed for extension - needs to be abstract, final or empty. |
209
|
| Parameter key should be final. |
209
|
| Expected @param tag for 'key'. |
209
|
| Expected an @return tag. |
219
|
| Method 'getDom' is not designed for extension - needs to be abstract, final or empty. |
219
|
| Parameter key should be final. |
219
|
| Expected @param tag for 'key'. |
219
|
| Line has trailing spaces. |
222
|
| Expected an @return tag. |
228
|
| Method 'getDom' is not designed for extension - needs to be abstract, final or empty. |
228
|
| Parameter key should be final. |
228
|
| Expected @param tag for 'key'. |
228
|
| Parameter defaultDom should be final. |
228
|
| Expected @param tag for 'defaultDom'. |
228
|
| '}' should be on the same line. |
231
|
| Line has trailing spaces. |
235
|
| Expected an @return tag. |
243
|
| Method 'getDom' is not designed for extension - needs to be abstract, final or empty. |
243
|
| Parameter key should be final. |
243
|
| Expected @param tag for 'key'. |
243
|
| Parameter defaultUrl should be final. |
243
|
| Expected @param tag for 'defaultUrl'. |
243
|
| '}' should be on the same line. |
246
|
| '+' is not preceded with whitespace. |
248
|
| '+' is not followed by whitespace. |
248
|
| '+' is not preceded with whitespace. |
248
|
| '+' is not followed by whitespace. |
248
|
| Line has trailing spaces. |
250
|
| Expected an @return tag. |
255
|
| Parameter key should be final. |
255
|
| Expected @param tag for 'key'. |
255
|
| Parameter source should be final. |
255
|
| Expected @param tag for 'source'. |
255
|
| '}' should be on the same line. |
258
|
| Line is longer than 80 characters. |
260
|
| '+' is not preceded with whitespace. |
260
|
| '+' is not followed by whitespace. |
260
|
| '+' is not preceded with whitespace. |
260
|
| '+' is not followed by whitespace. |
260
|
| '+' is not preceded with whitespace. |
260
|
| '+' is not followed by whitespace. |
260
|
| '+' is not preceded with whitespace. |
260
|
| '+' is not followed by whitespace. |
260
|
| '}' should be on the same line. |
261
|
| Line is longer than 80 characters. |
263
|
| '+' is not preceded with whitespace. |
263
|
| '+' is not followed by whitespace. |
263
|
| '+' is not preceded with whitespace. |
263
|
| '+' is not followed by whitespace. |
263
|
| '+' is not preceded with whitespace. |
263
|
| '+' is not followed by whitespace. |
263
|
| '+' is not preceded with whitespace. |
263
|
| '+' is not followed by whitespace. |
263
|
| Line is longer than 80 characters. |
267
|
| Line is longer than 80 characters. |
268
|
| Line is longer than 80 characters. |
274
|
| Expected an @return tag. |
283
|
| Parameter givenFilename should be final. |
283
|
| Expected @param tag for 'givenFilename'. |
283
|
| Expected @throws tag for 'IOException'. |
283
|
| Line has trailing spaces. |
284
|
| '+' is not preceded with whitespace. |
293
|
| '+' is not followed by whitespace. |
293
|
| '+' is not preceded with whitespace. |
293
|
| '+' is not followed by whitespace. |
293
|
| Line has trailing spaces. |
295
|
| '}' should be on the same line. |
302
|
| '{' should be on the previous line. |
304
|
| Line has trailing spaces. |
307
|
| '}' should be on the same line. |
310
|
| Line is longer than 80 characters. |
317
|
| '+' is not preceded with whitespace. |
317
|
| '+' is not followed by whitespace. |
317
|
| Expected an @return tag. |
326
|
| Parameter givenSource should be final. |
326
|
| Expected @param tag for 'givenSource'. |
326
|
| Line has trailing spaces. |
327
|
| Line has trailing spaces. |
329
|
| '>' is not preceded with whitespace. |
330
|
| '>' is not followed by whitespace. |
330
|
| 'if' construct must use '{}'s. |
333
|
| Line is longer than 80 characters. |
333
|
| '==' is not preceded with whitespace. |
333
|
| '==' is not followed by whitespace. |
333
|
| '+' is not preceded with whitespace. |
333
|
| '+' is not followed by whitespace. |
333
|
| '+' is not preceded with whitespace. |
333
|
| '+' is not followed by whitespace. |
333
|
| Line has trailing spaces. |
334
|
| '+' is not preceded with whitespace. |
335
|
| '+' is not followed by whitespace. |
335
|
| ',' is not followed by whitespace. |
335
|
| Line has trailing spaces. |
337
|
| 'if' construct must use '{}'s. |
338
|
| Line is longer than 80 characters. |
338
|
| '+' is not preceded with whitespace. |
338
|
| '+' is not followed by whitespace. |
338
|
| '+' is not preceded with whitespace. |
338
|
| '+' is not followed by whitespace. |
338
|
| '+' is not preceded with whitespace. |
338
|
| '+' is not followed by whitespace. |
338
|
| Line has trailing spaces. |
339
|
| '+' is not preceded with whitespace. |
340
|
| '+' is not preceded with whitespace. |
340
|
| '+' is not followed by whitespace. |
340
|
| Line has trailing spaces. |
342
|
| Line has trailing spaces. |
346
|
| First sentence should end with a period. |
347
|
| Expected an @return tag. |
348
|
| Method 'getClass' is not designed for extension - needs to be abstract, final or empty. |
348
|
| Parameter key should be final. |
348
|
| Expected @param tag for 'key'. |
348
|
| Line has trailing spaces. |
350
|
| '}' should be on the same line. |
353
|
| Line is longer than 80 characters. |
355
|
| '+' is not preceded with whitespace. |
355
|
| '+' is not followed by whitespace. |
355
|
| '+' is not preceded with whitespace. |
355
|
| '+' is not followed by whitespace. |
355
|
| '+' is not preceded with whitespace. |
355
|
| '+' is not followed by whitespace. |
355
|
| '+' is not preceded with whitespace. |
355
|
| '+' is not followed by whitespace. |
355
|
| '+' is not preceded with whitespace. |
355
|
| '+' is not followed by whitespace. |
355
|
| Method 'getClass' is not designed for extension - needs to be abstract, final or empty. |
359
|
| Missing a Javadoc comment. |
359
|
| Parameter key should be final. |
359
|
| Parameter defaultClass should be final. |
359
|
| '}' should be on the same line. |
362
|
| Line has trailing spaces. |
366
|
| Line has trailing spaces. |
368
|
| First sentence should end with a period. |
369
|
| Line is longer than 80 characters. |
369
|
| Expected an @return tag. |
370
|
| Method 'getInstance' is not designed for extension - needs to be abstract, final or empty. |
370
|
| Parameter key should be final. |
370
|
| Expected @param tag for 'key'. |
370
|
| Expected @throws tag for 'Throwable'. |
370
|
| '}' should be on the same line. |
374
|
| Line is longer than 80 characters. |
376
|
| '+' is not preceded with whitespace. |
376
|
| '+' is not followed by whitespace. |
376
|
| '+' is not preceded with whitespace. |
376
|
| '+' is not followed by whitespace. |
376
|
| '+' is not preceded with whitespace. |
376
|
| '+' is not followed by whitespace. |
376
|
| Line has trailing spaces. |
379
|
| Line is longer than 80 characters. |
381
|
| Line is longer than 80 characters. |
383
|
| Expected an @return tag. |
386
|
| Line is longer than 80 characters. |
386
|
| Parameter classToMake should be final. |
386
|
| Expected @param tag for 'classToMake'. |
386
|
| Expected @throws tag for 'InvocationTargetException'. |
386
|
| Expected @throws tag for 'InstantiationException'. |
386
|
| Expected @throws tag for 'IllegalAccessException'. |
386
|
| Expected @throws tag for 'IllegalArgumentException'. |
386
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
386
|
| Expected @throws tag for 'SecurityException'. |
386
|
| Redundant throws: 'SecurityException' is unchecked exception. |
386
|
| Expected @throws tag for 'NoSuchMethodException'. |
386
|
| Line has trailing spaces. |
387
|
| Line is longer than 80 characters. |
389
|
| Line is longer than 80 characters. |
390
|
| Line is longer than 80 characters. |
391
|
| Line is longer than 80 characters. |
393
|
| Line is longer than 80 characters. |
394
|
| '{' is followed by whitespace. |
396
|
| '{' is followed by whitespace. |
397
|
| ')' is preceded with whitespace. |
397
|
| Line has trailing spaces. |
398
|
| Line has trailing spaces. |
400
|
org/astrogrid/cfg/FailbackConfig.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line is longer than 80 characters. |
7
|
| Using the '.*' form of import should be avoided - java.util.*. |
12
|
| Using the '.*' form of import should be avoided - javax.naming.*. |
13
|
| Line is longer than 80 characters. |
32
|
| Line is longer than 80 characters. |
34
|
| Line is longer than 80 characters. |
41
|
| Line is longer than 80 characters. |
42
|
| Line has trailing spaces. |
44
|
| Line is longer than 80 characters. |
44
|
| Line is longer than 80 characters. |
45
|
| Line has trailing spaces. |
46
|
| Line is longer than 80 characters. |
46
|
| Line is longer than 80 characters. |
49
|
| Line is longer than 80 characters. |
51
|
| Line is longer than 80 characters. |
52
|
| Line is longer than 80 characters. |
61
|
| First sentence should end with a period. |
73
|
| First sentence should end with a period. |
77
|
| Missing a Javadoc comment. |
79
|
| Line has trailing spaces. |
80
|
| First sentence should end with a period. |
81
|
| Line has trailing spaces. |
83
|
| First sentence should end with a period. |
84
|
| Line has trailing spaces. |
86
|
| First sentence should end with a period. |
87
|
| Line has trailing spaces. |
89
|
| First sentence should end with a period. |
90
|
| Line is longer than 80 characters. |
93
|
| First sentence should end with a period. |
96
|
| Line has trailing spaces. |
98
|
| First sentence should end with a period. |
99
|
| Parameter context should be final. |
106
|
| Expected @param tag for 'context'. |
106
|
| Line has trailing spaces. |
108
|
| Method 'setConfigFilename' is not designed for extension - needs to be abstract, final or empty. |
114
|
| Parameter newName should be final. |
114
|
| Expected @param tag for 'newName'. |
114
|
| '{' should be on the previous line. |
115
|
| Line is longer than 80 characters. |
117
|
| ',' is not followed by whitespace. |
117
|
| Line has trailing spaces. |
121
|
| Line has trailing spaces. |
122
|
| Line is longer than 80 characters. |
125
|
| Line has trailing spaces. |
128
|
| Line has trailing spaces. |
130
|
| Line has trailing spaces. |
132
|
| Line has trailing spaces. |
135
|
| Line is longer than 80 characters. |
137
|
| Line has trailing spaces. |
138
|
| '}' should be on the same line. |
140
|
| Line is longer than 80 characters. |
141
|
| Must have at least one statement. |
141
|
| Line has trailing spaces. |
142
|
| '+' is not preceded with whitespace. |
143
|
| '+' is not followed by whitespace. |
143
|
| '+' is not preceded with whitespace. |
143
|
| '+' is not followed by whitespace. |
143
|
| '}' should be on the same line. |
144
|
| Line is longer than 80 characters. |
147
|
| '+' is not preceded with whitespace. |
147
|
| '+' is not followed by whitespace. |
147
|
| '+' is not preceded with whitespace. |
147
|
| '+' is not followed by whitespace. |
147
|
| '}' should be on the same line. |
149
|
| Line is longer than 80 characters. |
152
|
| '+' is not preceded with whitespace. |
152
|
| '+' is not followed by whitespace. |
152
|
| '+' is not preceded with whitespace. |
152
|
| '+' is not followed by whitespace. |
152
|
| '}' should be on the same line. |
154
|
| Line has trailing spaces. |
156
|
| Line has trailing spaces. |
161
|
| Line is longer than 80 characters. |
163
|
| Line has trailing spaces. |
167
|
| Line has trailing spaces. |
169
|
| Line has trailing spaces. |
173
|
| '+' is not preceded with whitespace. |
179
|
| '+' is not followed by whitespace. |
179
|
| '+' is not preceded with whitespace. |
180
|
| '+' is not followed by whitespace. |
180
|
| Line has trailing spaces. |
182
|
| Line is longer than 80 characters. |
185
|
| ';' is not followed by whitespace. |
185
|
| Must have at least one statement. |
187
|
| '+' is not preceded with whitespace. |
188
|
| '+' is not followed by whitespace. |
188
|
| '+' is not preceded with whitespace. |
188
|
| '+' is not followed by whitespace. |
188
|
| '+' is not preceded with whitespace. |
188
|
| '+' is not followed by whitespace. |
188
|
| Line is longer than 80 characters. |
190
|
| Must have at least one statement. |
191
|
| '+' is not preceded with whitespace. |
192
|
| '+' is not followed by whitespace. |
192
|
| '+' is not preceded with whitespace. |
192
|
| '+' is not followed by whitespace. |
192
|
| '+' is not preceded with whitespace. |
192
|
| '+' is not followed by whitespace. |
192
|
| Line has trailing spaces. |
193
|
| Line is longer than 80 characters. |
194
|
| Line is longer than 80 characters. |
197
|
| '+' is not preceded with whitespace. |
197
|
| '+' is not followed by whitespace. |
197
|
| '+' is not preceded with whitespace. |
197
|
| '+' is not followed by whitespace. |
197
|
| '+' is not preceded with whitespace. |
197
|
| '+' is not followed by whitespace. |
197
|
| '+' is not preceded with whitespace. |
197
|
| '+' is not followed by whitespace. |
197
|
| Line is longer than 80 characters. |
203
|
| Expression can be simplified. |
205
|
| '{' should be on the previous line. |
206
|
| Line is longer than 80 characters. |
221
|
| '+' is not preceded with whitespace. |
221
|
| '+' is not followed by whitespace. |
221
|
| '+' is not preceded with whitespace. |
221
|
| '+' is not followed by whitespace. |
221
|
| '+' is not preceded with whitespace. |
221
|
| '+' is not followed by whitespace. |
221
|
| '+' is not preceded with whitespace. |
221
|
| '+' is not followed by whitespace. |
221
|
| Line has trailing spaces. |
222
|
| '}' should be on the same line. |
225
|
| Line is longer than 80 characters. |
227
|
| '+' is not preceded with whitespace. |
227
|
| '+' is not followed by whitespace. |
227
|
| '+' is not preceded with whitespace. |
227
|
| '+' is not followed by whitespace. |
227
|
| '+' is not preceded with whitespace. |
227
|
| '+' is not followed by whitespace. |
227
|
| '+' is not preceded with whitespace. |
227
|
| '+' is not followed by whitespace. |
227
|
| ',' is not followed by whitespace. |
227
|
| '}' should be on the same line. |
228
|
| Line is longer than 80 characters. |
230
|
| '+' is not preceded with whitespace. |
230
|
| '+' is not followed by whitespace. |
230
|
| '+' is not preceded with whitespace. |
230
|
| '+' is not followed by whitespace. |
230
|
| '+' is not preceded with whitespace. |
230
|
| '+' is not followed by whitespace. |
230
|
| '+' is not preceded with whitespace. |
230
|
| '+' is not followed by whitespace. |
230
|
| ',' is not followed by whitespace. |
230
|
| '}' should be on the same line. |
231
|
| Line is longer than 80 characters. |
233
|
| '+' is not preceded with whitespace. |
233
|
| '+' is not followed by whitespace. |
233
|
| '+' is not preceded with whitespace. |
233
|
| '+' is not followed by whitespace. |
233
|
| '+' is not preceded with whitespace. |
233
|
| '+' is not followed by whitespace. |
233
|
| '+' is not preceded with whitespace. |
233
|
| '+' is not followed by whitespace. |
233
|
| '}' should be on the same line. |
234
|
| Line is longer than 80 characters. |
236
|
| '+' is not preceded with whitespace. |
236
|
| '+' is not followed by whitespace. |
236
|
| '+' is not preceded with whitespace. |
236
|
| '+' is not followed by whitespace. |
236
|
| '+' is not preceded with whitespace. |
236
|
| '+' should be on a new line. |
236
|
| Line is longer than 80 characters. |
237
|
| '+' is not preceded with whitespace. |
237
|
| '+' is not followed by whitespace. |
237
|
| '+' is not preceded with whitespace. |
237
|
| '+' is not followed by whitespace. |
237
|
| '+' is not preceded with whitespace. |
245
|
| '+' is not followed by whitespace. |
245
|
| '+' is not preceded with whitespace. |
245
|
| '+' is not followed by whitespace. |
245
|
| '+' is not preceded with whitespace. |
245
|
| '+' is not followed by whitespace. |
245
|
| Line has trailing spaces. |
249
|
| Line has trailing spaces. |
251
|
| Line is longer than 80 characters. |
252
|
| '+' is not preceded with whitespace. |
252
|
| '+' is not followed by whitespace. |
252
|
| '+' is not preceded with whitespace. |
252
|
| '+' is not followed by whitespace. |
252
|
| '+' is not preceded with whitespace. |
252
|
| '+' is not followed by whitespace. |
252
|
| '+' is not preceded with whitespace. |
252
|
| '+' is not followed by whitespace. |
252
|
| Line has trailing spaces. |
253
|
| '}' should be on the same line. |
255
|
| Line is longer than 80 characters. |
257
|
| '+' is not preceded with whitespace. |
257
|
| '+' should be on a new line. |
257
|
| '+' is not preceded with whitespace. |
258
|
| '+' is not followed by whitespace. |
258
|
| ',' is not followed by whitespace. |
258
|
| '}' should be on the same line. |
259
|
| Line is longer than 80 characters. |
261
|
| '+' is not preceded with whitespace. |
261
|
| '+' is not followed by whitespace. |
261
|
| '+' is not preceded with whitespace. |
261
|
| '+' is not followed by whitespace. |
261
|
| '+' is not preceded with whitespace. |
261
|
| '+' should be on a new line. |
261
|
| Line is longer than 80 characters. |
262
|
| '+' is not preceded with whitespace. |
262
|
| '+' is not followed by whitespace. |
262
|
| '+' is not preceded with whitespace. |
262
|
| '+' is not followed by whitespace. |
262
|
| Line is longer than 80 characters. |
267
|
| Line is longer than 80 characters. |
268
|
| '+' is not preceded with whitespace. |
268
|
| '+' is not followed by whitespace. |
268
|
| '}' should be on the same line. |
274
|
| Line is longer than 80 characters. |
276
|
| Line is longer than 80 characters. |
277
|
| Line is longer than 80 characters. |
278
|
| '+' is not preceded with whitespace. |
280
|
| '+' is not followed by whitespace. |
280
|
| Line has trailing spaces. |
282
|
| Line is longer than 80 characters. |
284
|
| '}' should be on the same line. |
289
|
| Line is longer than 80 characters. |
291
|
| Line is longer than 80 characters. |
292
|
| Line is longer than 80 characters. |
293
|
| '+' is not preceded with whitespace. |
295
|
| '+' is not followed by whitespace. |
295
|
| Line has trailing spaces. |
297
|
| Line has trailing spaces. |
298
|
| Line is longer than 80 characters. |
299
|
| '+' is not preceded with whitespace. |
301
|
| '+' should be on a new line. |
301
|
| Line is longer than 80 characters. |
302
|
| '+' is not preceded with whitespace. |
302
|
| '+' is not followed by whitespace. |
302
|
| '+' is not preceded with whitespace. |
302
|
| '+' is not followed by whitespace. |
302
|
| '+' is not preceded with whitespace. |
302
|
| '+' is not followed by whitespace. |
302
|
| '+' is not preceded with whitespace. |
302
|
| '+' is not followed by whitespace. |
302
|
| '+' is not preceded with whitespace. |
302
|
| '+' should be on a new line. |
302
|
| '+' is not preceded with whitespace. |
303
|
| '+' is not followed by whitespace. |
303
|
| '+' is not preceded with whitespace. |
303
|
| '+' is not followed by whitespace. |
303
|
| '+' is not preceded with whitespace. |
303
|
| '+' should be on a new line. |
303
|
| Line is longer than 80 characters. |
304
|
| '+' is not preceded with whitespace. |
304
|
| '+' is not followed by whitespace. |
304
|
| '+' is not preceded with whitespace. |
304
|
| '+' is not followed by whitespace. |
304
|
| Line is longer than 80 characters. |
309
|
| Expected an @return tag. |
313
|
| Parameter givenFilename should be final. |
313
|
| Expected @param tag for 'givenFilename'. |
313
|
| Line has trailing spaces. |
317
|
| '+' is not preceded with whitespace. |
320
|
| '+' is not followed by whitespace. |
320
|
| '+' is not preceded with whitespace. |
323
|
| '+' is not followed by whitespace. |
323
|
| Line has trailing spaces. |
324
|
| Line has trailing spaces. |
334
|
| Line is longer than 80 characters. |
336
|
| Line is longer than 80 characters. |
337
|
| '+' is not preceded with whitespace. |
338
|
| '+' is not followed by whitespace. |
338
|
| '+' is not preceded with whitespace. |
338
|
| '+' is not followed by whitespace. |
338
|
| Line has trailing spaces. |
344
|
| Line is longer than 80 characters. |
345
|
| '+' is not preceded with whitespace. |
345
|
| '+' is not followed by whitespace. |
345
|
| '+' is not preceded with whitespace. |
345
|
| '+' is not followed by whitespace. |
345
|
| Line has trailing spaces. |
346
|
| Line has trailing spaces. |
348
|
| Line is longer than 80 characters. |
350
|
| '+' is not preceded with whitespace. |
350
|
| '+' is not followed by whitespace. |
350
|
| '+' is not preceded with whitespace. |
350
|
| '+' is not followed by whitespace. |
350
|
| '+' is not preceded with whitespace. |
350
|
| '+' is not followed by whitespace. |
350
|
| Line has trailing spaces. |
353
|
| Line has trailing spaces. |
354
|
| '+' is not preceded with whitespace. |
356
|
| '+' is not followed by whitespace. |
356
|
| '+' is not preceded with whitespace. |
356
|
| '+' is not followed by whitespace. |
356
|
| Line has trailing spaces. |
361
|
| Line has trailing spaces. |
364
|
| First sentence should end with a period. |
365
|
| Parameter f should be final. |
366
|
| Expected @param tag for 'f'. |
366
|
| '+' is not preceded with whitespace. |
369
|
| '+' is not followed by whitespace. |
369
|
| '+' is not preceded with whitespace. |
369
|
| '+' is not followed by whitespace. |
369
|
| '}' should be on the same line. |
371
|
| Line is longer than 80 characters. |
373
|
| '+' is not preceded with whitespace. |
373
|
| '+' is not followed by whitespace. |
373
|
| '+' is not preceded with whitespace. |
373
|
| '+' is not followed by whitespace. |
373
|
| Line has trailing spaces. |
376
|
| Line has trailing spaces. |
377
|
| Line has trailing spaces. |
378
|
| Method 'loadFromUrl' is not designed for extension - needs to be abstract, final or empty. |
385
|
| Parameter url should be final. |
385
|
| Expected @param tag for 'url'. |
385
|
| Expected @throws tag for 'IOException'. |
385
|
| Line has trailing spaces. |
396
|
| Line is longer than 80 characters. |
397
|
| Line is longer than 80 characters. |
399
|
| ';' is preceded with whitespace. |
399
|
| Line is longer than 80 characters. |
403
|
| '+' is not preceded with whitespace. |
403
|
| '+' is not followed by whitespace. |
403
|
| '+' is not preceded with whitespace. |
403
|
| '+' is not followed by whitespace. |
403
|
| Line has trailing spaces. |
406
|
| Line has trailing spaces. |
409
|
| Line has trailing spaces. |
411
|
| First sentence should end with a period. |
412
|
| Line is longer than 80 characters. |
413
|
| Parameter key should be final. |
416
|
| Expected @param tag for 'key'. |
416
|
| '{' should be on the previous line. |
417
|
| Line is longer than 80 characters. |
418
|
| '+' is not preceded with whitespace. |
418
|
| '+' is not followed by whitespace. |
418
|
| '+' is not preceded with whitespace. |
418
|
| '+' is not followed by whitespace. |
418
|
| Line is longer than 80 characters. |
419
|
| '+' is not preceded with whitespace. |
419
|
| '+' is not followed by whitespace. |
419
|
| '+' is not preceded with whitespace. |
419
|
| '+' is not followed by whitespace. |
419
|
| Line is longer than 80 characters. |
420
|
| '+' is not preceded with whitespace. |
420
|
| '+' is not followed by whitespace. |
420
|
| '+' is not preceded with whitespace. |
420
|
| '+' is not followed by whitespace. |
420
|
| Expected an @return tag. |
427
|
| Method 'getProperty' is not designed for extension - needs to be abstract, final or empty. |
427
|
| Parameter key should be final. |
427
|
| Expected @param tag for 'key'. |
427
|
| Line has trailing spaces. |
432
|
| Line has trailing spaces. |
437
|
| Line has trailing spaces. |
441
|
| '+' is not preceded with whitespace. |
444
|
| '+' is not followed by whitespace. |
444
|
| '}' should be on the same line. |
445
|
| '}' should be on the same line. |
449
|
| Must have at least one statement. |
450
|
| '}' should be on the same line. |
450
|
| '+' is not preceded with whitespace. |
452
|
| '+' is not followed by whitespace. |
452
|
| '+' is not preceded with whitespace. |
452
|
| '+' is not followed by whitespace. |
452
|
| '+' is not preceded with whitespace. |
452
|
| '+' is not followed by whitespace. |
452
|
| '+' is not followed by whitespace. |
459
|
| '}' should be on the same line. |
460
|
| '+' is not followed by whitespace. |
463
|
| '+' is not preceded with whitespace. |
463
|
| '+' is not followed by whitespace. |
463
|
| '+' is not preceded with whitespace. |
463
|
| '+' is not followed by whitespace. |
463
|
| Line has trailing spaces. |
464
|
| Line has trailing spaces. |
469
|
| '+' is not followed by whitespace. |
471
|
| Line has trailing spaces. |
476
|
| Line is longer than 80 characters. |
477
|
| '+' is not preceded with whitespace. |
477
|
| '+' is not followed by whitespace. |
477
|
| '+' is not preceded with whitespace. |
477
|
| '+' is not followed by whitespace. |
477
|
| '+' is not preceded with whitespace. |
477
|
| '+' is not followed by whitespace. |
477
|
| Method 'setProperty' is not designed for extension - needs to be abstract, final or empty. |
485
|
| Parameter key should be final. |
485
|
| Expected @param tag for 'key'. |
485
|
| Parameter value should be final. |
485
|
| Expected @param tag for 'value'. |
485
|
| Line is longer than 80 characters. |
498
|
| Expected an @return tag. |
501
|
| Method 'getProperties' is not designed for extension - needs to be abstract, final or empty. |
501
|
| Parameter key should be final. |
501
|
| Expected @param tag for 'key'. |
501
|
| Line has trailing spaces. |
506
|
| '}' should be on the same line. |
512
|
| '{' is followed by whitespace. |
514
|
| Line has trailing spaces. |
517
|
| 'cast' is not followed by whitespace. |
524
|
| '+' is not preceded with whitespace. |
525
|
| '+' is not followed by whitespace. |
525
|
| Line is longer than 80 characters. |
530
|
| '=' is not preceded with whitespace. |
534
|
| '=' is not followed by whitespace. |
534
|
| '+' is not preceded with whitespace. |
534
|
| '+' is not followed by whitespace. |
534
|
| '}' should be on the same line. |
539
|
| '}' should be on the same line. |
543
|
| Must have at least one statement. |
544
|
| '}' should be on the same line. |
544
|
| '+' is not preceded with whitespace. |
546
|
| '+' is not followed by whitespace. |
546
|
| '+' is not preceded with whitespace. |
546
|
| '+' is not followed by whitespace. |
546
|
| '+' is not preceded with whitespace. |
546
|
| '+' is not followed by whitespace. |
546
|
| '+' is not followed by whitespace. |
555
|
| '}' should be on the same line. |
556
|
| '+' is not followed by whitespace. |
558
|
| '+' is not preceded with whitespace. |
558
|
| '+' is not followed by whitespace. |
558
|
| '+' is not preceded with whitespace. |
558
|
| '+' is not followed by whitespace. |
558
|
| '+' is not preceded with whitespace. |
561
|
| '+' is not followed by whitespace. |
561
|
| Line has trailing spaces. |
562
|
| Line is longer than 80 characters. |
563
|
| Line is longer than 80 characters. |
565
|
| '+' is not preceded with whitespace. |
565
|
| '+' is not followed by whitespace. |
565
|
| '+' is not preceded with whitespace. |
565
|
| '+' is not followed by whitespace. |
565
|
| '{' is followed by whitespace. |
570
|
| Line has trailing spaces. |
572
|
| '+' is not preceded with whitespace. |
578
|
| '+' is not followed by whitespace. |
578
|
| '+' is not preceded with whitespace. |
578
|
| '+' is not followed by whitespace. |
578
|
| Line has trailing spaces. |
583
|
| Line has trailing spaces. |
585
|
| '+' is not followed by whitespace. |
587
|
| '{' is followed by whitespace. |
590
|
| Line has trailing spaces. |
592
|
| Line is longer than 80 characters. |
593
|
| '+' is not preceded with whitespace. |
593
|
| '+' is not followed by whitespace. |
593
|
| '+' is not preceded with whitespace. |
593
|
| '+' is not followed by whitespace. |
593
|
| '+' is not preceded with whitespace. |
593
|
| '+' is not followed by whitespace. |
593
|
| Line is longer than 80 characters. |
597
|
| Method 'setProperties' is not designed for extension - needs to be abstract, final or empty. |
600
|
| Parameter key should be final. |
600
|
| Expected @param tag for 'key'. |
600
|
| Parameter values should be final. |
600
|
| Expected @param tag for 'values'. |
600
|
| Line is longer than 80 characters. |
612
|
| Expected an @return tag. |
615
|
| Method 'keySet' is not designed for extension - needs to be abstract, final or empty. |
615
|
| Line has trailing spaces. |
619
|
| Line has trailing spaces. |
621
|
| '}' should be on the same line. |
630
|
| Line is longer than 80 characters. |
632
|
| '+' is not preceded with whitespace. |
632
|
| '+' is not followed by whitespace. |
632
|
| ',' is not followed by whitespace. |
632
|
| Line has trailing spaces. |
635
|
| Line has trailing spaces. |
646
|
| First sentence should end with a period. |
647
|
| Method 'dumpConfig' is not designed for extension - needs to be abstract, final or empty. |
650
|
| Parameter writer should be final. |
650
|
| Expected @param tag for 'writer'. |
650
|
| Line has trailing spaces. |
651
|
| Line has trailing spaces. |
653
|
| '+' is not preceded with whitespace. |
654
|
| '+' is not followed by whitespace. |
654
|
| '}' should be on the same line. |
660
|
| Line has trailing spaces. |
669
|
| 'cast' is not followed by whitespace. |
683
|
| 'cast' is not followed by whitespace. |
687
|
| Line is longer than 80 characters. |
689
|
| Must have at least one statement. |
692
|
| Line has trailing spaces. |
695
|
| '}' should be on the same line. |
696
|
| '}' should be on the same line. |
701
|
| Line has trailing spaces. |
706
|
| Line is longer than 80 characters. |
713
|
| '}' should be on the same line. |
715
|
| '}' should be on the same line. |
729
|
| Line is longer than 80 characters. |
731
|
| '+' is not preceded with whitespace. |
732
|
| '+' is not followed by whitespace. |
732
|
| Line has trailing spaces. |
737
|
| First sentence should end with a period. |
738
|
| Parameter args should be final. |
741
|
| Expected @param tag for 'args'. |
741
|
| Line is longer than 80 characters. |
771
|
| Line is longer than 80 characters. |
774
|
org/astrogrid/cfg/PropertyNotFoundException.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line is longer than 80 characters. |
7
|
| Line has trailing spaces. |
21
|
| Missing a Javadoc comment. |
22
|
| Parameter msg should be final. |
22
|
| Line has trailing spaces. |
25
|
org/astrogrid/cfg/UserOptions.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - java.io.*. |
9
|
| Missing a Javadoc comment. |
27
|
| Variable 'properties' must be private and have accessor methods. |
27
|
| Missing a Javadoc comment. |
29
|
| Variable 'file' must be private and have accessor methods. |
29
|
| Line has trailing spaces. |
30
|
| Missing a Javadoc comment. |
31
|
| Variable 'header' must be private and have accessor methods. |
31
|
| Line has trailing spaces. |
32
|
| First sentence should end with a period. |
33
|
| Line is longer than 80 characters. |
33
|
| Parameter filename should be final. |
34
|
| Expected @param tag for 'filename'. |
34
|
| Expected @throws tag for 'IOException'. |
34
|
| '+' is not preceded with whitespace. |
35
|
| '+' is not followed by whitespace. |
35
|
| '}' should be on the same line. |
38
|
| '+' is not preceded with whitespace. |
41
|
| '+' is not followed by whitespace. |
41
|
| '+' is not preceded with whitespace. |
41
|
| '+' is not followed by whitespace. |
41
|
| Line has trailing spaces. |
44
|
| Expected an @return tag. |
47
|
| Method 'getProperty' is not designed for extension - needs to be abstract, final or empty. |
47
|
| Parameter key should be final. |
47
|
| Expected @param tag for 'key'. |
47
|
| Expected @throws tag for 'PropertyNotFoundException'. |
47
|
| Redundant throws: 'PropertyNotFoundException' is unchecked exception. |
47
|
| '+' is not preceded with whitespace. |
50
|
| '+' is not followed by whitespace. |
50
|
| '+' is not preceded with whitespace. |
50
|
| '+' is not followed by whitespace. |
50
|
| Line is longer than 80 characters. |
55
|
| Method 'setProperty' is not designed for extension - needs to be abstract, final or empty. |
56
|
| Parameter key should be final. |
56
|
| Expected @param tag for 'key'. |
56
|
| Parameter value should be final. |
56
|
| Expected @param tag for 'value'. |
56
|
| Line has trailing spaces. |
59
|
| Line is longer than 80 characters. |
60
|
| Expected an @return tag. |
62
|
| Method 'getProperties' is not designed for extension - needs to be abstract, final or empty. |
62
|
| Parameter key should be final. |
62
|
| Expected @param tag for 'key'. |
62
|
| Expected @throws tag for 'PropertyNotFoundException'. |
62
|
| Redundant throws: 'PropertyNotFoundException' is unchecked exception. |
62
|
| '+' is not preceded with whitespace. |
64
|
| '+' is not followed by whitespace. |
64
|
| Line has trailing spaces. |
65
|
| Line is longer than 80 characters. |
66
|
| Line is longer than 80 characters. |
68
|
| '+' is not preceded with whitespace. |
68
|
| '+' is not followed by whitespace. |
68
|
| '+' is not preceded with whitespace. |
68
|
| '+' is not followed by whitespace. |
68
|
| '+' is not preceded with whitespace. |
68
|
| '+' is not followed by whitespace. |
68
|
| '{' is followed by whitespace. |
73
|
| Line has trailing spaces. |
75
|
| '+' is not preceded with whitespace. |
81
|
| '+' is not followed by whitespace. |
81
|
| '+' is not preceded with whitespace. |
81
|
| '+' is not followed by whitespace. |
81
|
| Line has trailing spaces. |
86
|
| '+' is not preceded with whitespace. |
87
|
| '+' is not followed by whitespace. |
87
|
| '+' is not preceded with whitespace. |
87
|
| '+' is not followed by whitespace. |
87
|
| First sentence should end with a period. |
90
|
| Method 'setProperties' is not designed for extension - needs to be abstract, final or empty. |
91
|
| Parameter key should be final. |
91
|
| Expected @param tag for 'key'. |
91
|
| Parameter values should be final. |
91
|
| Expected @param tag for 'values'. |
91
|
| '+' is not preceded with whitespace. |
93
|
| '+' is not followed by whitespace. |
93
|
| '+' is not preceded with whitespace. |
93
|
| '+' is not followed by whitespace. |
93
|
| Line has trailing spaces. |
96
|
| Line is longer than 80 characters. |
97
|
| Method 'loadFromUrl' is not designed for extension - needs to be abstract, final or empty. |
99
|
| Parameter url should be final. |
99
|
| Expected @param tag for 'url'. |
99
|
| Expected @throws tag for 'IOException'. |
99
|
| Method 'dumpConfig' is not designed for extension - needs to be abstract, final or empty. |
105
|
| Parameter writer should be final. |
105
|
| Expected @param tag for 'writer'. |
105
|
| Line has trailing spaces. |
113
|
| First sentence should end with a period. |
114
|
| Expected an @return tag. |
115
|
| Method 'keySet' is not designed for extension - needs to be abstract, final or empty. |
115
|
| Line has trailing spaces. |
118
|
| First sentence should end with a period. |
119
|
| Method 'store' is not designed for extension - needs to be abstract, final or empty. |
120
|
| Expected @throws tag for 'IOException'. |
120
|
| Line has trailing spaces. |
123
|