PMD Results

The following document contains the results of PMD.

Summary

FilesErrors
18131

Files

FilesViolations
org/astrogrid/registry/server/DefaultChecker.java 2
org/astrogrid/registry/server/XSLHelper.java 3
org/astrogrid/registry/server/admin/AdminChecker.java 5
org/astrogrid/registry/server/admin/AuthorityListManager.java 2
org/astrogrid/registry/server/admin/RegistryAdminService.java 34
org/astrogrid/registry/server/harvest/HarvestChecker.java 5
org/astrogrid/registry/server/harvest/RegistryHarvestAdmin.java 13
org/astrogrid/registry/server/harvest/RegistryHarvestService.java 24
org/astrogrid/registry/server/http/filters/RestrictFilter.java 2
org/astrogrid/registry/server/http/servlets/HarvestDaemon.java 1
org/astrogrid/registry/server/http/servlets/helper/JSPHelper.java 1
org/astrogrid/registry/server/query/DefaultOAIService.java 7
org/astrogrid/registry/server/query/DefaultQueryService.java 11
org/astrogrid/registry/server/query/ProcessResults.java 2
org/astrogrid/registry/server/query/QueryChecker.java 6
org/astrogrid/registry/server/query/QueryConfigExtractor.java 4
org/astrogrid/registry/server/query/QueryHelper.java 7
org/astrogrid/registry/server/xmldb/XMLDBRegistry.java 2

org/astrogrid/registry/server/DefaultChecker.java

ViolationLine
No need to import a type that's in the same package 3
No need to import a type that's in the same package 4

org/astrogrid/registry/server/XSLHelper.java

ViolationLine
Avoid duplicate imports such as 'java.io.InputStream' 6
Avoid unused imports such as 'DomHelper' 18
Avoid unused local variables such as 'resultDoc' 84

org/astrogrid/registry/server/admin/AdminChecker.java

ViolationLine
Avoid unused imports such as 'RegistryValidator' 6
Avoid unused imports such as 'NodeList' 8
Avoid unused imports such as 'AssertionFailedError' 9
Avoid unused imports such as 'IOException' 10
Avoid unused imports such as 'DomHelper' 13

org/astrogrid/registry/server/admin/AuthorityListManager.java

ViolationLine
Avoid unused local variables such as 'sameRegistry' 133
Avoid unused local variables such as 'regAuthID' 134

org/astrogrid/registry/server/admin/RegistryAdminService.java

ViolationLine
Avoid unused imports such as 'Attr' 9
Avoid unused imports such as 'Subject' 11
Avoid unused imports such as 'DocumentBuilderFactory' 13
Avoid unused imports such as 'DocumentBuilder' 14
Avoid unused imports such as 'SAXParser' 16
Avoid unused imports such as 'SAXParserFactory' 17
Avoid duplicate imports such as 'javax.xml.parsers.ParserConfigurationException' 18
Avoid unused imports such as 'DefaultHandler' 20
Avoid unused imports such as 'InputSource' 21
Avoid unused imports such as 'SAXException' 22
Avoid unused imports such as 'SAXNotRecognizedException' 23
Avoid unused imports such as 'SAXNotSupportedException' 24
Avoid unused imports such as 'HashSet' 27
Avoid unused imports such as 'Iterator' 29
Avoid unused imports such as 'QueryConfigExtractor' 35
Avoid unused imports such as 'DefaultQueryService' 41
Avoid unused imports such as 'RegistryHarvestService' 42
Avoid unused imports such as 'ByteArrayInputStream' 51
Avoid unused imports such as 'ByteArrayOutputStream' 52
Avoid unused imports such as 'IOException' 53
Avoid unused imports such as 'StringReader' 54
Avoid unused imports such as 'URL' 56
Avoid unused imports such as 'HttpURLConnection' 57
Avoid unused imports such as 'MalformedURLException' 58
Avoid unused imports such as 'DateFormat' 60
Avoid unused private fields such as 'AUTHORITYID_PROPERTY' 101
Avoid unused local variables such as 'defaultNS' 182
Avoid unused local variables such as 'attrVersion' 197
Avoid unused local variables such as 'vrNS' 214
Avoid unused local variables such as 'al' 296
Avoid unused local variables such as 'xql' 297
Avoid unused local variables such as 'df' 298
Avoid unused local variables such as 'resultDoc' 300
Avoid unused local variables such as 'attrNodeTest' 335

org/astrogrid/registry/server/harvest/HarvestChecker.java

ViolationLine
Avoid unused private fields such as 'QUERY_ROOT' 17
Avoid unused private fields such as 'OAI_NAMESPACE' 19
Avoid unused private methods such as 'checkOAIPiece' 52
Avoid empty 'if' statements 55
Avoid empty 'if' statements 57

org/astrogrid/registry/server/harvest/RegistryHarvestAdmin.java

ViolationLine
Avoid unused imports such as 'AdminHelper' 5
Avoid unused imports such as 'AuthorityListManager' 7
Avoid unused imports such as 'NamedNodeMap' 18
Avoid unused imports such as 'Attr' 19
Avoid unused imports such as 'ResourceSet' 21
Avoid unused imports such as 'XMLResource' 22
Avoid unused local variables such as 'al' 62
Avoid unused local variables such as 'xql' 63
Avoid unused local variables such as 'df' 64
Avoid unused local variables such as 'resultDoc' 66
Avoid unused local variables such as 'addManageError' 69
Avoid unused local variables such as 'vrNS' 101
Avoid unused local variables such as 'defaultNS' 104

org/astrogrid/registry/server/harvest/RegistryHarvestService.java

ViolationLine
Avoid unused imports such as 'Reader' 6
Avoid unused imports such as 'StringReader' 7
Avoid unused imports such as 'DocumentBuilderFactory' 12
Avoid unused imports such as 'DocumentBuilder' 13
Avoid unused imports such as 'XSLHelper' 31
Avoid unused imports such as 'HashMap' 38
Avoid unused imports such as 'Hashtable' 41
Avoid unused imports such as 'MalformedURLException' 49
Avoid unused imports such as 'ResourceSet' 51
Avoid unused imports such as 'Resource' 53
Avoid unused private fields such as 'HARVEST_TEMPLATE_URL_PROPERTY' 67
Avoid unused local variables such as 'xqlQuery' 99
Avoid unused local variables such as 'collectionName' 110
Avoid unused local variables such as 'xdb' 112
Avoid unused local variables such as 'coll' 113
Avoid unused local variables such as 'failureCount' 219
Avoid unused local variables such as 'resumptionSuccess' 220
Avoid unused local variables such as 'isRegistryType' 223
Avoid unused local variables such as 'doc' 224
Avoid unused local variables such as 'soapActionURI' 226
Avoid unused local variables such as 'sdf' 227
Avoid unused local variables such as 'attributes' 230
Avoid unused local variables such as 'isRegistryType' 277
Avoid unused local variables such as 'childElem' 475

org/astrogrid/registry/server/http/filters/RestrictFilter.java

ViolationLine
Avoid unused private fields such as 'contextURL' 23
Avoid unused private fields such as 'adminPassword' 25

org/astrogrid/registry/server/http/servlets/HarvestDaemon.java

ViolationLine
Avoid unused private fields such as 'context' 55

org/astrogrid/registry/server/http/servlets/helper/JSPHelper.java

ViolationLine
Avoid unused imports such as 'HttpSession' 3

org/astrogrid/registry/server/query/DefaultOAIService.java

ViolationLine
Avoid unused imports such as 'Reader' 7
Avoid unused imports such as 'StringReader' 8
Avoid unused imports such as 'XSLHelper' 18
Avoid unused imports such as 'RegistryException' 20
Avoid unused imports such as 'ArrayList' 29
Avoid unused local variables such as 'doc' 90
Avoid unused private methods such as 'getOAIServletURL' 115

org/astrogrid/registry/server/query/DefaultQueryService.java

ViolationLine
Avoid unused imports such as 'Element' 4
Avoid unused imports such as 'NodeList' 6
Avoid unused imports such as 'RegistryException' 18
Avoid unused imports such as 'RegistryDOMHelper' 20
Avoid unused imports such as 'XSLHelper' 25
Avoid unused imports such as 'Ivorn' 26
Avoid unused imports such as 'XMLResource' 29
Avoid unused imports such as 'Resource' 30
Avoid unused imports such as 'Collection' 31
Avoid unused private fields such as 'voResourceVersion' 60
Avoid unused private fields such as 'AUTHORITYID_PROPERTY' 67

org/astrogrid/registry/server/query/ProcessResults.java

ViolationLine
Avoid unused imports such as 'SAXException' 14
Avoid unused imports such as 'DomHelper' 18

org/astrogrid/registry/server/query/QueryChecker.java

ViolationLine
Avoid unused imports such as 'RegistryValidator' 6
Avoid unused imports such as 'NodeList' 8
Avoid unused imports such as 'AssertionFailedError' 9
Avoid unused imports such as 'IOException' 10
Avoid unused imports such as 'DomHelper' 13
Avoid unused private fields such as 'QUERY_ROOT' 17

org/astrogrid/registry/server/query/QueryConfigExtractor.java

ViolationLine
Avoid unused imports such as 'Config' 3
Avoid unused local variables such as 'hasAuthorityID' 89
Avoid unused local variables such as 'hasAuthorityID' 105
Avoid unused local variables such as 'hasAuthorityID' 121

org/astrogrid/registry/server/query/QueryHelper.java

ViolationLine
Avoid unused imports such as 'Element' 6
Avoid unused imports such as 'NodeList' 8
Avoid unused imports such as 'URL' 16
Avoid unused imports such as 'MalformedURLException' 17
Avoid unused imports such as 'RegistryException' 24
Avoid unused imports such as 'XMLResource' 32
Avoid unused local variables such as 'coll' 290

org/astrogrid/registry/server/xmldb/XMLDBRegistry.java

ViolationLine
Avoid unused imports such as 'QueryConfigExtractor' 7
Avoid unused imports such as 'Resource' 16