Checkstyle Results
The following document contains the results of
Checkstyle
.
Summary
| Files | Infos | Warnings | Errors |
| 34 | 0 | 0 | 888 |
Files
org/astrogrid/ui/EscEnterListener.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - java.awt.event.*. |
11
|
| Line is longer than 80 characters. |
22
|
| Line is longer than 80 characters. |
40
|
| Missing a Javadoc comment. |
43
|
| '{' should be on the previous line. |
44
|
| Missing a Javadoc comment. |
45
|
| Variable 'defaultBtn' must be private and have accessor methods. |
45
|
| Missing a Javadoc comment. |
46
|
| Variable 'cancelBtn' must be private and have accessor methods. |
46
|
| Missing a Javadoc comment. |
47
|
| Variable 'window' must be private and have accessor methods. |
47
|
| First sentence should end with a period. |
49
|
| Line is longer than 80 characters. |
49
|
| Parameter aWindow should be final. |
52
|
| Expected @param tag for 'aWindow'. |
52
|
| Parameter aDefault should be final. |
52
|
| Expected @param tag for 'aDefault'. |
52
|
| Parameter aCancel should be final. |
52
|
| Expected @param tag for 'aCancel'. |
52
|
| '{' should be on the previous line. |
53
|
| First sentence should end with a period. |
57
|
| Line is longer than 80 characters. |
62
|
| Parameter aWindow should be final. |
62
|
| Expected @param tag for 'aWindow'. |
62
|
| Parameter aDefault should be final. |
62
|
| Expected @param tag for 'aDefault'. |
62
|
| Parameter aCancel should be final. |
62
|
| Expected @param tag for 'aCancel'. |
62
|
| Parameter disposeOnCancel should be final. |
62
|
| Expected @param tag for 'disposeOnCancel'. |
62
|
| Parameter e should be final. |
74
|
| '{' should be on the previous line. |
75
|
| '{' should be on the previous line. |
77
|
| '}' should be on the same line. |
80
|
| '{' should be on the previous line. |
82
|
| '{' should be on the previous line. |
90
|
| Parameter e should be final. |
95
|
| '{' should be on the previous line. |
96
|
| First sentence should end with a period. |
104
|
| Method 'setCancelBtn' is not designed for extension - needs to be abstract, final or empty. |
106
|
| Parameter b should be final. |
106
|
| Expected @param tag for 'b'. |
106
|
| '{' should be on the previous line. |
107
|
| Method 'setDefaultBtn' is not designed for extension - needs to be abstract, final or empty. |
114
|
| Parameter b should be final. |
114
|
| Expected @param tag for 'b'. |
114
|
| '{' should be on the previous line. |
115
|
| 'if' construct must use '{}'s. |
117
|
| Method 'registerWith' is not designed for extension - needs to be abstract, final or empty. |
127
|
| Parameter comp should be final. |
127
|
| Expected @param tag for 'comp'. |
127
|
| '{' should be on the previous line. |
128
|
| '{' should be on the previous line. |
135
|
| '=' is not preceded with whitespace. |
137
|
| '=' is not followed by whitespace. |
137
|
| ';' is not followed by whitespace. |
137
|
| '<' is not preceded with whitespace. |
137
|
| '<' is not followed by whitespace. |
137
|
| ';' is not followed by whitespace. |
137
|
| '{' should be on the previous line. |
138
|
| Method 'keyPressed' is not designed for extension - needs to be abstract, final or empty. |
146
|
| Parameter ke should be final. |
146
|
| Expected @param tag for 'ke'. |
146
|
| '{' should be on the previous line. |
147
|
| Line is longer than 80 characters. |
148
|
| Line is longer than 80 characters. |
152
|
| '{' should be on the previous line. |
157
|
org/astrogrid/ui/ExtensionFileFilter.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - javax.swing.filechooser.*. |
38
|
| Line has trailing spaces. |
60
|
| Missing a Javadoc comment. |
61
|
| Name 'TYPE_UNKNOWN' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
61
|
| Missing a Javadoc comment. |
62
|
| Name 'HIDDEN_FILE' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
62
|
| Line has trailing spaces. |
63
|
| Missing a Javadoc comment. |
64
|
| Missing a Javadoc comment. |
65
|
| Missing a Javadoc comment. |
66
|
| Missing a Javadoc comment. |
67
|
| Line has trailing spaces. |
68
|
| Parameter filters should be final. |
87
|
| 'filters' hides a field. |
87
|
| Line is longer than 80 characters. |
92
|
| Parameter filters should be final. |
98
|
| 'filters' hides a field. |
98
|
| Parameter description should be final. |
98
|
| 'description' hides a field. |
98
|
| 'if' construct must use '{}'s. |
104
|
| 'if' is not followed by whitespace. |
104
|
| '!=' is not preceded with whitespace. |
104
|
| '!=' is not followed by whitespace. |
104
|
| Parameter extension should be final. |
112
|
| ',' is not followed by whitespace. |
113
|
| Parameter extension should be final. |
124
|
| Parameter description should be final. |
124
|
| 'description' hides a field. |
124
|
| 'if' construct must use '{}'s. |
126
|
| 'if' is not followed by whitespace. |
126
|
| '!=' is not preceded with whitespace. |
126
|
| '!=' is not followed by whitespace. |
126
|
| 'if' construct must use '{}'s. |
127
|
| 'if' is not followed by whitespace. |
127
|
| '!=' is not preceded with whitespace. |
127
|
| '!=' is not followed by whitespace. |
127
|
| Expected an @return tag. |
138
|
| Method 'accept' is not designed for extension - needs to be abstract, final or empty. |
138
|
| Parameter f should be final. |
138
|
| Expected @param tag for 'f'. |
138
|
| 'if' is not followed by whitespace. |
139
|
| 'if' is not followed by whitespace. |
140
|
| 'if' is not followed by whitespace. |
144
|
| Empty statement. |
146
|
| Method 'addExtension' is not designed for extension - needs to be abstract, final or empty. |
162
|
| Parameter extension should be final. |
162
|
| Expected @param tag for 'extension'. |
162
|
| 'if' is not followed by whitespace. |
163
|
| '5' is a magic number. |
164
|
| Expected an @return tag. |
178
|
| Method 'getDescription' is not designed for extension - needs to be abstract, final or empty. |
178
|
| 'if' is not followed by whitespace. |
179
|
| 'if' is not followed by whitespace. |
180
|
| '==' is not preceded with whitespace. |
181
|
| '==' is not followed by whitespace. |
181
|
| Avoid inline conditionals. |
181
|
| 'if' is not followed by whitespace. |
184
|
| Expected an @return tag. |
203
|
| Method 'getExtension' is not designed for extension - needs to be abstract, final or empty. |
203
|
| Parameter f should be final. |
203
|
| Expected @param tag for 'f'. |
203
|
| 'if' is not followed by whitespace. |
204
|
| 'if' is not followed by whitespace. |
207
|
| '>' is not preceded with whitespace. |
207
|
| '>' is not followed by whitespace. |
207
|
| '<' is not preceded with whitespace. |
207
|
| '<' is not followed by whitespace. |
207
|
| '-' is not preceded with whitespace. |
207
|
| '-' is not followed by whitespace. |
207
|
| '+' is not preceded with whitespace. |
208
|
| '+' is not followed by whitespace. |
208
|
| Empty statement. |
209
|
| Expected an @return tag. |
224
|
| Method 'isExtensionListInDescription' is not designed for extension - needs to be abstract, final or empty. |
224
|
| Method 'setDescription' is not designed for extension - needs to be abstract, final or empty. |
235
|
| Parameter description should be final. |
235
|
| 'description' hides a field. |
235
|
| Expected @param tag for 'description'. |
235
|
| Method 'setExtensionListInDescription' is not designed for extension - needs to be abstract, final or empty. |
250
|
| Parameter b should be final. |
250
|
| Expected @param tag for 'b'. |
250
|
org/astrogrid/ui/FlexiGridLayout.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - java.awt.*. |
13
|
| Missing a Javadoc comment. |
15
|
| '{' should be on the previous line. |
16
|
| Missing a Javadoc comment. |
17
|
| Variable 'numCols' must be private and have accessor methods. |
17
|
| Missing a Javadoc comment. |
19
|
| Variable 'addCol' must be private and have accessor methods. |
19
|
| Missing a Javadoc comment. |
22
|
| Variable 'vGap' must be private and have accessor methods. |
22
|
| Missing a Javadoc comment. |
23
|
| Variable 'hGap' must be private and have accessor methods. |
23
|
| Missing a Javadoc comment. |
25
|
| Parameter cols should be final. |
25
|
| '{' should be on the previous line. |
26
|
| First sentence should end with a period. |
31
|
| Method 'addLayoutComponent' is not designed for extension - needs to be abstract, final or empty. |
34
|
| Parameter aComponent should be final. |
34
|
| Expected @param tag for 'aComponent'. |
34
|
| Parameter unusedConstraint should be final. |
34
|
| Expected @param tag for 'unusedConstraint'. |
34
|
| ',' is not followed by whitespace. |
40
|
| ',' is not followed by whitespace. |
40
|
| ',' is not followed by whitespace. |
40
|
| '-' is not preceded with whitespace. |
42
|
| '-' is not followed by whitespace. |
42
|
| '{' should be on the previous line. |
43
|
| '}' should be on the same line. |
46
|
| '{' should be on the previous line. |
48
|
| '++' is preceded with whitespace. |
49
|
| Method 'setColWidth' is not designed for extension - needs to be abstract, final or empty. |
54
|
| Missing a Javadoc comment. |
54
|
| Parameter col should be final. |
54
|
| Parameter newWidth should be final. |
54
|
| '{' should be on the previous line. |
55
|
| 'if' construct must use '{}'s. |
56
|
| Method 'setHGap' is not designed for extension - needs to be abstract, final or empty. |
66
|
| Parameter gap should be final. |
66
|
| Expected @param tag for 'gap'. |
66
|
| '{' should be on the previous line. |
67
|
| Method 'setVGap' is not designed for extension - needs to be abstract, final or empty. |
75
|
| Parameter gap should be final. |
75
|
| Expected @param tag for 'gap'. |
75
|
| '{' should be on the previous line. |
76
|
| Missing a Javadoc comment. |
80
|
| Parameter args should be final. |
80
|
| '{' should be on the previous line. |
81
|
| '4' is a magic number. |
84
|
| '300' is a magic number. |
97
|
| ',' is not followed by whitespace. |
97
|
| '300' is a magic number. |
97
|
| ',' is not followed by whitespace. |
98
|
| '100' is a magic number. |
98
|
org/astrogrid/ui/GridBagHelper.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| First sentence should end with a period. |
10
|
| Utility classes should not have a public or default constructor. |
18
|
| '{' should be on the previous line. |
19
|
| First sentence should end with a period. |
20
|
| Parameter constraints should be final. |
24
|
| Expected @param tag for 'constraints'. |
24
|
| '{' should be on the previous line. |
25
|
| First sentence should end with a period. |
34
|
| Parameter constraints should be final. |
38
|
| Expected @param tag for 'constraints'. |
38
|
| '{' should be on the previous line. |
39
|
| Parameter constraints should be final. |
54
|
| Expected @param tag for 'constraints'. |
54
|
| '{' should be on the previous line. |
55
|
| '3' is a magic number. |
60
|
org/astrogrid/ui/GridLayout2.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - java.awt.*. |
3
|
| Missing a Javadoc comment. |
6
|
| '{' should be on the previous line. |
7
|
| Missing a Javadoc comment. |
8
|
| Missing a Javadoc comment. |
12
|
| Parameter rows should be final. |
12
|
| Parameter cols should be final. |
12
|
| Missing a Javadoc comment. |
16
|
| Parameter rows should be final. |
16
|
| Parameter cols should be final. |
16
|
| Parameter hgap should be final. |
16
|
| Parameter vgap should be final. |
16
|
| Method 'preferredLayoutSize' is not designed for extension - needs to be abstract, final or empty. |
20
|
| Missing a Javadoc comment. |
20
|
| Parameter parent should be final. |
20
|
| '}' should be on the same line. |
29
|
| '++' is preceded with whitespace. |
35
|
| '++' is preceded with whitespace. |
48
|
| '++' is preceded with whitespace. |
52
|
| Line is longer than 80 characters. |
55
|
| '-' is not preceded with whitespace. |
55
|
| '-' is not followed by whitespace. |
55
|
| '*' is not preceded with whitespace. |
55
|
| '*' is not followed by whitespace. |
55
|
| '-' is not preceded with whitespace. |
56
|
| '-' is not followed by whitespace. |
56
|
| '*' is not preceded with whitespace. |
56
|
| '*' is not followed by whitespace. |
56
|
| Method 'minimumLayoutSize' is not designed for extension - needs to be abstract, final or empty. |
60
|
| Missing a Javadoc comment. |
60
|
| Parameter parent should be final. |
60
|
| '}' should be on the same line. |
69
|
| '++' is preceded with whitespace. |
75
|
| '++' is preceded with whitespace. |
88
|
| '++' is preceded with whitespace. |
92
|
| Line is longer than 80 characters. |
95
|
| '-' is not preceded with whitespace. |
95
|
| '-' is not followed by whitespace. |
95
|
| '*' is not preceded with whitespace. |
95
|
| '*' is not followed by whitespace. |
95
|
| '-' is not preceded with whitespace. |
96
|
| '-' is not followed by whitespace. |
96
|
| '*' is not preceded with whitespace. |
96
|
| '*' is not followed by whitespace. |
96
|
| Method 'layoutContainer' is not designed for extension - needs to be abstract, final or empty. |
100
|
| Missing a Javadoc comment. |
100
|
| Parameter parent should be final. |
100
|
| '}' should be on the same line. |
112
|
| '++' is preceded with whitespace. |
125
|
| '++' is preceded with whitespace. |
139
|
| '++' is preceded with whitespace. |
140
|
org/astrogrid/ui/IconButtonHelper.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Redundant import from the same package - org.astrogrid.ui.IconFactory. |
20
|
| Missing a Javadoc comment. |
22
|
| Utility classes should not have a public or default constructor. |
22
|
| '{' should be on the previous line. |
23
|
| First sentence should end with a period. |
24
|
| Line is longer than 80 characters. |
24
|
| Expected an @return tag. |
25
|
| Parameter title should be final. |
25
|
| Expected @param tag for 'title'. |
25
|
| '{' should be on the previous line. |
26
|
| First sentence should end with a period. |
30
|
| Line is longer than 80 characters. |
30
|
| Expected an @return tag. |
31
|
| Line is longer than 80 characters. |
31
|
| Parameter title should be final. |
31
|
| Expected @param tag for 'title'. |
31
|
| Parameter iconname should be final. |
31
|
| Expected @param tag for 'iconname'. |
31
|
| Parameter tooltip should be final. |
31
|
| Expected @param tag for 'tooltip'. |
31
|
| '{' should be on the previous line. |
36
|
| '}' should be on the same line. |
38
|
| '{' should be on the previous line. |
40
|
| ',' is not followed by whitespace. |
42
|
| ',' is not followed by whitespace. |
42
|
| ',' is not followed by whitespace. |
42
|
| '+' is not preceded with whitespace. |
44
|
| '+' is not followed by whitespace. |
44
|
| '+' is not preceded with whitespace. |
44
|
| '+' is not followed by whitespace. |
44
|
| Line has trailing spaces. |
46
|
| First sentence should end with a period. |
51
|
| Parameter buttons should be final. |
54
|
| Expected @param tag for 'buttons'. |
54
|
| '{' should be on the previous line. |
55
|
| '=' is not preceded with whitespace. |
59
|
| '=' is not followed by whitespace. |
59
|
| ';' is not followed by whitespace. |
59
|
| '<' is not preceded with whitespace. |
59
|
| '<' is not followed by whitespace. |
59
|
| ';' is not followed by whitespace. |
59
|
| '{' should be on the previous line. |
60
|
| 'if' construct must use '{}'s. |
65
|
| '<' is not preceded with whitespace. |
65
|
| '<' is not followed by whitespace. |
65
|
| '=' is not preceded with whitespace. |
69
|
| '=' is not followed by whitespace. |
69
|
| ';' is not followed by whitespace. |
69
|
| '<' is not preceded with whitespace. |
69
|
| '<' is not followed by whitespace. |
69
|
| ';' is not followed by whitespace. |
69
|
| '{' should be on the previous line. |
70
|
| '+' is not preceded with whitespace. |
72
|
| '+' is not followed by whitespace. |
72
|
| '+' is not preceded with whitespace. |
72
|
| '+' is not followed by whitespace. |
72
|
| '+' is not preceded with whitespace. |
74
|
| '+' is not followed by whitespace. |
74
|
| Line has trailing spaces. |
78
|
org/astrogrid/ui/IconFactory.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line is longer than 80 characters. |
7
|
| Unused import - java.awt.Toolkit. |
14
|
| Unused import - java.io.IOException. |
15
|
| Unused import - java.io.InputStream. |
16
|
| Unused import - java.net.URL. |
17
|
| Unused import - javax.imageio.ImageIO. |
19
|
| Unused import - org.apache.commons.logging.LogFactory. |
22
|
| First sentence should end with a period. |
24
|
| '{' should be on the previous line. |
34
|
| Missing a Javadoc comment. |
35
|
| Missing a Javadoc comment. |
36
|
| Missing a Javadoc comment. |
37
|
| Missing a Javadoc comment. |
40
|
| '{' is followed by whitespace. |
40
|
| '16' is a magic number. |
40
|
| '32' is a magic number. |
40
|
| '64' is a magic number. |
40
|
| Line is longer than 80 characters. |
43
|
| Missing a Javadoc comment. |
43
|
| Name 'cache' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
43
|
| '{' is followed by whitespace. |
43
|
| Expected an @return tag. |
48
|
| Parameter iconName should be final. |
48
|
| Expected @param tag for 'iconName'. |
48
|
| '{' should be on the previous line. |
49
|
| Expected an @return tag. |
57
|
| Parameter iconName should be final. |
57
|
| Expected @param tag for 'iconName'. |
57
|
| '{' should be on the previous line. |
58
|
| First sentence should end with a period. |
62
|
| Line is longer than 80 characters. |
65
|
| Expected an @return tag. |
67
|
| Parameter iconName should be final. |
67
|
| Expected @param tag for 'iconName'. |
67
|
| Parameter size should be final. |
67
|
| Expected @param tag for 'size'. |
67
|
| '{' should be on the previous line. |
68
|
| Line is longer than 80 characters. |
69
|
| Line has trailing spaces. |
70
|
| 'if' construct must use '{}'s. |
73
|
| '+' is not preceded with whitespace. |
77
|
| '+' is not followed by whitespace. |
77
|
| '<=' is not preceded with whitespace. |
78
|
| '<=' is not followed by whitespace. |
78
|
| '{' should be on the previous line. |
79
|
| Line is longer than 80 characters. |
93
|
| ',' is not followed by whitespace. |
93
|
| First sentence should end with a period. |
101
|
| Expected an @return tag. |
104
|
| Parameter filename should be final. |
104
|
| Expected @param tag for 'filename'. |
104
|
| '{' should be on the previous line. |
105
|
| '+' is not preceded with whitespace. |
106
|
| '+' is not followed by whitespace. |
106
|
org/astrogrid/ui/ImageFactory.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line is longer than 80 characters. |
7
|
| First sentence should end with a period. |
22
|
| Utility classes should not have a public or default constructor. |
31
|
| '{' should be on the previous line. |
32
|
| Missing a Javadoc comment. |
34
|
| Name 'imageCache' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
34
|
| Line is longer than 80 characters. |
36
|
| Expected an @return tag. |
39
|
| Parameter imageName should be final. |
39
|
| Expected @param tag for 'imageName'. |
39
|
| '{' should be on the previous line. |
40
|
| Line has trailing spaces. |
48
|
| '+' is not preceded with whitespace. |
50
|
| '+' is not followed by whitespace. |
50
|
| Line has trailing spaces. |
52
|
| First sentence should end with a period. |
56
|
| Expected an @return tag. |
59
|
| Parameter filename should be final. |
59
|
| Expected @param tag for 'filename'. |
59
|
| '{' should be on the previous line. |
60
|
| Line is longer than 80 characters. |
61
|
| '+' is not preceded with whitespace. |
62
|
| '+' is not followed by whitespace. |
62
|
| Line is longer than 80 characters. |
64
|
| '+' is not preceded with whitespace. |
64
|
| '+' is not followed by whitespace. |
64
|
| '+' is not preceded with whitespace. |
64
|
| '+' is not followed by whitespace. |
64
|
| '+' is not preceded with whitespace. |
64
|
| '+' is not followed by whitespace. |
64
|
| Line has trailing spaces. |
70
|
| Line is longer than 80 characters. |
72
|
| '+' is not preceded with whitespace. |
72
|
| '+' is not followed by whitespace. |
72
|
| '}' should be on the same line. |
76
|
| Must have at least one statement. |
77
|
| First sentence should end with a period. |
84
|
| Line is longer than 80 characters. |
85
|
| Expected an @return tag. |
87
|
| Parameter givenClass should be final. |
87
|
| Expected @param tag for 'givenClass'. |
87
|
| Parameter filename should be final. |
87
|
| Expected @param tag for 'filename'. |
87
|
| '{' should be on the previous line. |
88
|
| '+' is not preceded with whitespace. |
89
|
| '+' is not followed by whitespace. |
89
|
| Line is longer than 80 characters. |
98
|
| '+' is not preceded with whitespace. |
98
|
| '+' is not followed by whitespace. |
98
|
| '}' should be on the same line. |
102
|
| Must have at least one statement. |
103
|
org/astrogrid/ui/JHistoryComboBox.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line is longer than 80 characters. |
7
|
| First sentence should end with a period. |
17
|
| '{' should be on the previous line. |
27
|
| Missing a Javadoc comment. |
28
|
| '{' should be on the previous line. |
29
|
| Line has trailing spaces. |
32
|
| Parameter e should be final. |
36
|
| '{' should be on the previous line. |
37
|
| Method 'setDefaultList' is not designed for extension - needs to be abstract, final or empty. |
44
|
| Missing a Javadoc comment. |
44
|
| Parameter list should be final. |
44
|
| '{' should be on the previous line. |
45
|
| '=' is not preceded with whitespace. |
46
|
| '=' is not followed by whitespace. |
46
|
| '<' is not preceded with whitespace. |
46
|
| '<' is not followed by whitespace. |
46
|
| '{' should be on the previous line. |
47
|
| First sentence should end with a period. |
52
|
| Method 'updateList' is not designed for extension - needs to be abstract, final or empty. |
54
|
| Parameter item should be final. |
54
|
| Expected @param tag for 'item'. |
54
|
| '{' should be on the previous line. |
55
|
| '=' is not preceded with whitespace. |
56
|
| '=' is not followed by whitespace. |
56
|
| ';' is not followed by whitespace. |
56
|
| '<' is not preceded with whitespace. |
56
|
| '<' is not followed by whitespace. |
56
|
| ';' is not followed by whitespace. |
56
|
| Line has trailing spaces. |
64
|
| First sentence should end with a period. |
65
|
| Method 'setItem' is not designed for extension - needs to be abstract, final or empty. |
68
|
| Parameter newEntry should be final. |
68
|
| Expected @param tag for 'newEntry'. |
68
|
| '{' should be on the previous line. |
69
|
| Line has trailing spaces. |
73
|
| Method 'getText' is not designed for extension - needs to be abstract, final or empty. |
74
|
| Missing a Javadoc comment. |
74
|
| '{' should be on the previous line. |
75
|
| Line has trailing spaces. |
78
|
org/astrogrid/ui/JPasteButton.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Unused import - java.awt.datatransfer.Clipboard. |
9
|
| Unused import - javax.swing.JComboBox. |
12
|
| First sentence should end with a period. |
15
|
| '{' should be on the previous line. |
24
|
| Missing a Javadoc comment. |
25
|
| Variable 'textField' must be private and have accessor methods. |
25
|
| Missing a Javadoc comment. |
26
|
| Variable 'comboBox' must be private and have accessor methods. |
26
|
| Missing a Javadoc comment. |
28
|
| Parameter defHeight should be final. |
28
|
| '{' should be on the previous line. |
29
|
| Line has trailing spaces. |
31
|
| Line has trailing spaces. |
34
|
| '==' is not preceded with whitespace. |
35
|
| '==' is not followed by whitespace. |
35
|
| '{' should be on the previous line. |
36
|
| '}' should be on the same line. |
38
|
| '{' should be on the previous line. |
40
|
| Line has trailing spaces. |
45
|
| Missing a Javadoc comment. |
46
|
| Parameter aField should be final. |
46
|
| '{' should be on the previous line. |
47
|
| Line has trailing spaces. |
49
|
| Missing a Javadoc comment. |
53
|
| Parameter aField should be final. |
53
|
| '{' should be on the previous line. |
54
|
| Line has trailing spaces. |
56
|
| Method 'actionPerformed' is not designed for extension - needs to be abstract, final or empty. |
60
|
| Missing a Javadoc comment. |
60
|
| Parameter e should be final. |
60
|
| '{' should be on the previous line. |
61
|
| '{' should be on the previous line. |
63
|
| Line has trailing spaces. |
67
|
| '{' should be on the previous line. |
69
|
| Line has trailing spaces. |
74
|
org/astrogrid/ui/JSetFileButton.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Unused import - java.awt.BorderLayout. |
9
|
| Unused import - java.awt.Insets. |
10
|
| Unused import - javax.swing.BorderFactory. |
15
|
| Unused import - javax.swing.Icon. |
16
|
| '{' should be on the previous line. |
32
|
| Missing a Javadoc comment. |
33
|
| Missing a Javadoc comment. |
34
|
| Missing a Javadoc comment. |
35
|
| Missing a Javadoc comment. |
37
|
| '{' should be on the previous line. |
38
|
| '{' should be on the previous line. |
44
|
| '}' should be on the same line. |
46
|
| '{' should be on the previous line. |
48
|
| Missing a Javadoc comment. |
60
|
| Parameter textField should be final. |
60
|
| 'textField' hides a field. |
60
|
| '{' should be on the previous line. |
61
|
| First sentence should end with a period. |
67
|
| Method 'setChooser' is not designed for extension - needs to be abstract, final or empty. |
70
|
| Parameter specialChooser should be final. |
70
|
| Expected @param tag for 'specialChooser'. |
70
|
| '{' should be on the previous line. |
71
|
| First sentence should end with a period. |
75
|
| Expected an @return tag. |
78
|
| Method 'getChooser' is not designed for extension - needs to be abstract, final or empty. |
78
|
| '{' should be on the previous line. |
79
|
| First sentence should end with a period. |
83
|
| Method 'addChoosableFilter' is not designed for extension - needs to be abstract, final or empty. |
86
|
| Parameter specialFilter should be final. |
86
|
| Expected @param tag for 'specialFilter'. |
86
|
| '{' should be on the previous line. |
87
|
| First sentence should end with a period. |
91
|
| Method 'setFilter' is not designed for extension - needs to be abstract, final or empty. |
94
|
| Parameter specialFilter should be final. |
94
|
| Expected @param tag for 'specialFilter'. |
94
|
| '{' should be on the previous line. |
95
|
| First sentence should end with a period. |
100
|
| Method 'setTextField' is not designed for extension - needs to be abstract, final or empty. |
103
|
| Parameter givenField should be final. |
103
|
| Expected @param tag for 'givenField'. |
103
|
| '{' should be on the previous line. |
104
|
| '{' should be on the previous line. |
108
|
| First sentence should end with a period. |
117
|
| Method 'setComboBox' is not designed for extension - needs to be abstract, final or empty. |
120
|
| Parameter givenCombo should be final. |
120
|
| Expected @param tag for 'givenCombo'. |
120
|
| '{' should be on the previous line. |
121
|
| '{' should be on the previous line. |
125
|
| Method 'actionPerformed' is not designed for extension - needs to be abstract, final or empty. |
139
|
| Parameter e should be final. |
139
|
| Expected @param tag for 'e'. |
139
|
| '{' should be on the previous line. |
140
|
| '{' should be on the previous line. |
144
|
| First sentence should end with a period. |
150
|
| Method 'fileChosen' is not designed for extension - needs to be abstract, final or empty. |
153
|
| Parameter givenFile should be final. |
153
|
| Expected @param tag for 'givenFile'. |
153
|
| '{' should be on the previous line. |
154
|
| '{' should be on the previous line. |
156
|
| '{' should be on the previous line. |
161
|
| First sentence should end with a period. |
166
|
| Expected an @return tag. |
169
|
| Method 'getChosenFile' is not designed for extension - needs to be abstract, final or empty. |
169
|
| '{' should be on the previous line. |
170
|
org/astrogrid/ui/Splash.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Using the '.*' form of import should be avoided - java.awt.*. |
11
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
12
|
| '{' should be on the previous line. |
39
|
| First sentence should end with a period. |
40
|
| Parameter imageName should be final. |
44
|
| Expected @param tag for 'imageName'. |
44
|
| '{' should be on the previous line. |
45
|
| '+' is not preceded with whitespace. |
46
|
| '+' is not followed by whitespace. |
46
|
| '+' is not preceded with whitespace. |
46
|
| '+' is not followed by whitespace. |
46
|
| First sentence should end with a period. |
49
|
| Parameter file should be final. |
52
|
| Expected @param tag for 'file'. |
52
|
| '{' should be on the previous line. |
53
|
| First sentence should end with a period. |
57
|
| Parameter url should be final. |
60
|
| Expected @param tag for 'url'. |
60
|
| '{' should be on the previous line. |
61
|
| Line has trailing spaces. |
64
|
| Line has trailing spaces. |
65
|
| First sentence should end with a period. |
66
|
| Parameter splashImage should be final. |
68
|
| Expected @param tag for 'splashImage'. |
68
|
| '{' should be on the previous line. |
69
|
| First sentence should end with a period. |
74
|
| '{' is not followed by whitespace. |
77
|
| '}' is not preceded with whitespace. |
77
|
| First sentence should end with a period. |
79
|
| Parameter title should be final. |
80
|
| Expected @param tag for 'title'. |
80
|
| Parameter subtitle should be final. |
80
|
| Expected @param tag for 'subtitle'. |
80
|
| Parameter version should be final. |
80
|
| Expected @param tag for 'version'. |
80
|
| Parameter bg should be final. |
81
|
| Expected @param tag for 'bg'. |
81
|
| Parameter fg should be final. |
81
|
| Expected @param tag for 'fg'. |
81
|
| Parameter coyLogo should be final. |
82
|
| Expected @param tag for 'coyLogo'. |
82
|
| Parameter coyName should be final. |
82
|
| Expected @param tag for 'coyName'. |
82
|
| '{' should be on the previous line. |
83
|
| Method 'makeSplash' is not designed for extension - needs to be abstract, final or empty. |
88
|
| Missing a Javadoc comment. |
88
|
| Parameter title should be final. |
88
|
| Parameter subtitle should be final. |
88
|
| Parameter version should be final. |
88
|
| Parameter bg should be final. |
89
|
| Parameter fg should be final. |
89
|
| Parameter coyLogo should be final. |
90
|
| Parameter coyName should be final. |
90
|
| '{' should be on the previous line. |
91
|
| '10' is a magic number. |
98
|
| Line has trailing spaces. |
102
|
| Line is longer than 80 characters. |
107
|
| '24F' is a magic number. |
107
|
| '{' should be on the previous line. |
111
|
| '16F' is a magic number. |
113
|
| Line has trailing spaces. |
118
|
| Line has trailing spaces. |
130
|
| '12F' is a magic number. |
133
|
| 'if' construct must use '{}'s. |
135
|
| 'if' construct must use '{}'s. |
137
|
| '12F' is a magic number. |
141
|
| Line has trailing spaces. |
143
|
| Line has trailing spaces. |
148
|
| Line has trailing spaces. |
151
|
| First sentence should end with a period. |
152
|
| Method 'showCenter' is not designed for extension - needs to be abstract, final or empty. |
153
|
| '{' should be on the previous line. |
154
|
| '/' is not preceded with whitespace. |
159
|
| '/' is not followed by whitespace. |
159
|
| '/' is not preceded with whitespace. |
159
|
| '/' is not followed by whitespace. |
159
|
| '/' is not preceded with whitespace. |
160
|
| '/' is not followed by whitespace. |
160
|
| '/' is not preceded with whitespace. |
160
|
| '/' is not followed by whitespace. |
160
|
| Line has trailing spaces. |
164
|
| First sentence should end with a period. |
165
|
| Parameter args should be final. |
168
|
| Expected @param tag for 'args'. |
168
|
| '{' should be on the previous line. |
169
|
| ',' is not followed by whitespace. |
170
|
| Line has trailing spaces. |
174
|
org/astrogrid/ui/TreeModelSupport.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Missing a Javadoc comment. |
12
|
| Method 'addTreeModelListener' is not designed for extension - needs to be abstract, final or empty. |
14
|
| Missing a Javadoc comment. |
14
|
| '(' is followed by whitespace. |
14
|
| Parameter listener should be final. |
14
|
| ')' is preceded with whitespace. |
14
|
| '(' is followed by whitespace. |
15
|
| '(' is followed by whitespace. |
15
|
| ')' is preceded with whitespace. |
15
|
| ')' is preceded with whitespace. |
15
|
| '(' is followed by whitespace. |
16
|
| ')' is preceded with whitespace. |
16
|
| Method 'removeTreeModelListener' is not designed for extension - needs to be abstract, final or empty. |
20
|
| Missing a Javadoc comment. |
20
|
| '(' is followed by whitespace. |
20
|
| Parameter listener should be final. |
20
|
| ')' is preceded with whitespace. |
20
|
| '(' is followed by whitespace. |
21
|
| ')' is preceded with whitespace. |
21
|
| '(' is followed by whitespace. |
22
|
| ')' is preceded with whitespace. |
22
|
| Method 'fireTreeNodesChanged' is not designed for extension - needs to be abstract, final or empty. |
26
|
| Missing a Javadoc comment. |
26
|
| '(' is followed by whitespace. |
26
|
| Parameter e should be final. |
26
|
| ')' is preceded with whitespace. |
26
|
| '(' is followed by whitespace. |
28
|
| ')' is preceded with whitespace. |
28
|
| Line is longer than 80 characters. |
29
|
| 'cast' is not followed by whitespace. |
29
|
| '(' is followed by whitespace. |
30
|
| ')' is preceded with whitespace. |
30
|
| Method 'fireTreeNodesInserted' is not designed for extension - needs to be abstract, final or empty. |
34
|
| Missing a Javadoc comment. |
34
|
| '(' is followed by whitespace. |
34
|
| Parameter e should be final. |
34
|
| ')' is preceded with whitespace. |
34
|
| '(' is followed by whitespace. |
36
|
| ')' is preceded with whitespace. |
36
|
| Line is longer than 80 characters. |
37
|
| 'cast' is not followed by whitespace. |
37
|
| '(' is followed by whitespace. |
38
|
| ')' is preceded with whitespace. |
38
|
| Method 'fireTreeNodesRemoved' is not designed for extension - needs to be abstract, final or empty. |
42
|
| Missing a Javadoc comment. |
42
|
| '(' is followed by whitespace. |
42
|
| Parameter e should be final. |
42
|
| ')' is preceded with whitespace. |
42
|
| '(' is followed by whitespace. |
44
|
| ')' is preceded with whitespace. |
44
|
| Line is longer than 80 characters. |
45
|
| 'cast' is not followed by whitespace. |
45
|
| '(' is followed by whitespace. |
46
|
| ')' is preceded with whitespace. |
46
|
| Method 'fireTreeStructureChanged' is not designed for extension - needs to be abstract, final or empty. |
50
|
| Missing a Javadoc comment. |
50
|
| '(' is followed by whitespace. |
50
|
| Parameter e should be final. |
50
|
| ')' is preceded with whitespace. |
50
|
| '(' is followed by whitespace. |
52
|
| ')' is preceded with whitespace. |
52
|
| Line is longer than 80 characters. |
53
|
| 'cast' is not followed by whitespace. |
53
|
| '(' is followed by whitespace. |
54
|
| ')' is preceded with whitespace. |
54
|
org/astrogrid/ui/package.html
| Error | Line |
| Missing package documentation file. | 0 |
org/astrogrid/ui/votable/JVot.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line is longer than 80 characters. |
6
|
| First sentence should end with a period. |
17
|
| '{' should be on the previous line. |
25
|
| Missing a Javadoc comment. |
26
|
| Missing a Javadoc comment. |
28
|
| '{' should be on the previous line. |
29
|
| Method 'setVotModel' is not designed for extension - needs to be abstract, final or empty. |
32
|
| Missing a Javadoc comment. |
32
|
| Parameter givenVot should be final. |
32
|
| '{' should be on the previous line. |
33
|
| 'for' is not followed by whitespace. |
38
|
| '=' is not preceded with whitespace. |
38
|
| '=' is not followed by whitespace. |
38
|
| '<' is not preceded with whitespace. |
38
|
| '<' is not followed by whitespace. |
38
|
| '{' should be on the previous line. |
39
|
| 'cast' is not followed by whitespace. |
40
|
| '{' should be on the previous line. |
44
|
| '+' is not preceded with whitespace. |
45
|
| '+' is not followed by whitespace. |
45
|
| '+' is not preceded with whitespace. |
45
|
| '+' is not followed by whitespace. |
45
|
| Line has trailing spaces. |
47
|
| '+' is not preceded with whitespace. |
48
|
| '+' is not followed by whitespace. |
48
|
| '=' is not preceded with whitespace. |
53
|
| '=' is not followed by whitespace. |
53
|
| '<' is not preceded with whitespace. |
53
|
| '<' is not followed by whitespace. |
53
|
| '{' should be on the previous line. |
54
|
| '(' is followed by whitespace. |
56
|
| '=' is not preceded with whitespace. |
58
|
| '=' is not followed by whitespace. |
58
|
| '<' is not preceded with whitespace. |
58
|
| '<' is not followed by whitespace. |
58
|
| '{' should be on the previous line. |
59
|
| Method 'getVotModel' is not designed for extension - needs to be abstract, final or empty. |
68
|
| Missing a Javadoc comment. |
68
|
| '{' should be on the previous line. |
69
|
| First sentence should end with a period. |
73
|
| Expected an @return tag. |
77
|
| Method 'newVotScrollPanel' is not designed for extension - needs to be abstract, final or empty. |
77
|
| '{' should be on the previous line. |
78
|
| Line is longer than 80 characters. |
82
|
org/astrogrid/ui/votable/JVotBox.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line is longer than 80 characters. |
7
|
| Using the '.*' form of import should be avoided - java.awt.*. |
13
|
| Using the '.*' form of import should be avoided - java.awt.event.*. |
14
|
| Using the '.*' form of import should be avoided - javax.swing.*. |
15
|
| Missing a Javadoc comment. |
20
|
| '{' should be on the previous line. |
21
|
| Missing a Javadoc comment. |
22
|
| Variable 'votView' must be private and have accessor methods. |
22
|
| Missing a Javadoc comment. |
23
|
| Variable 'votController' must be private and have accessor methods. |
23
|
| Line has trailing spaces. |
24
|
| Line has trailing spaces. |
25
|
| Parameter owner should be final. |
29
|
| Expected @param tag for 'owner'. |
29
|
| '{' should be on the previous line. |
30
|
| Line has trailing spaces. |
39
|
| Line has trailing spaces. |
40
|
| Parameter e should be final. |
49
|
| '{' should be on the previous line. |
50
|
| '{' should be on the previous line. |
62
|
| '{' should be on the previous line. |
72
|
| First sentence should end with a period. |
85
|
| Expected an @return tag. |
88
|
| Method 'getVotTable' is not designed for extension - needs to be abstract, final or empty. |
88
|
| '{' should be on the previous line. |
89
|
| First sentence should end with a period. |
93
|
| Expected an @return tag. |
96
|
| Method 'getVotController' is not designed for extension - needs to be abstract, final or empty. |
96
|
| '{' should be on the previous line. |
97
|
| Method 'show' is not designed for extension - needs to be abstract, final or empty. |
103
|
| '{' should be on the previous line. |
104
|
| First sentence should end with a period. |
119
|
| Parameter args should be final. |
122
|
| Expected @param tag for 'args'. |
122
|
| '{' should be on the previous line. |
123
|
org/astrogrid/ui/votable/JVotController.java
| Error | Line |
| Line does not match expected header line of '<?xml version="1.0" encoding="UTF-8"?>'. |
1
|
| Line is longer than 80 characters. |
7
|
| Using the '.*' form of import should be avoided - java.io.*. |
12
|
| First sentence should end with a period. |
24
|
| '{' should be on the previous line. |
31
|
| Missing a Javadoc comment. |
32
|
| Missing a Javadoc comment. |
33
|
| Missing a Javadoc comment. |
34
|
| Missing a Javadoc comment. |
36
|
| Line is longer than 80 characters. |
38
|
| Missing a Javadoc comment. |
38
|
| Name 'votFileFilter' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
38
|
| ',' is not followed by whitespace. |
38
|
| Line is longer than 80 characters. |
39
|
| Missing a Javadoc comment. |
39
|
| Name 'xmlFileFilter' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
39
|
| ',' is not followed by whitespace. |
39
|
| Missing a Javadoc comment. |
41
|
| Variable 'log' must be private and have accessor methods. |
41
|
| Line has trailing spaces. |
42
|
| Missing a Javadoc comment. |
43
|
| Parameter view should be final. |
43
|
| '{' should be on the previous line. |
44
|
| Line has trailing spaces. |
46
|
| Method 'loadVot' is not designed for extension - needs to be abstract, final or empty. |
52
|
| Missing a Javadoc comment. |
52
|
| Parameter in should be final. |
52
|
| '{' should be on the previous line. |
53
|
| '{' should be on the previous line. |
59
|
| Line has trailing spaces. |
62
|
| '==' is not preceded with whitespace. |
66
|
| '==' is not followed by whitespace. |
66
|
| '{' should be on the previous line. |
67
|
| Missing a Javadoc comment. |
80
|
| Parameter errors should be final. |
80
|
| '{' should be on the previous line. |
81
|
| '{' should be on the previous line. |
83
|
| Line is longer than 80 characters. |
84
|
| '(' is followed by whitespace. |
84
|
| '+' is not preceded with whitespace. |
84
|
| '+' is not followed by whitespace. |
84
|
| Method 'saveVot' is not designed for extension - needs to be abstract, final or empty. |
88
|
| Missing a Javadoc comment. |
88
|
| Parameter out should be final. |
88
|
| '{' should be on the previous line. |
89
|
| Method 'actionPerformed' is not designed for extension - needs to be abstract, final or empty. |
106
|
| Parameter e should be final. |
106
|
| Expected @param tag for 'e'. |
106
|
| '{' should be on the previous line. |
107
|
| '{' should be on the previous line. |
109
|
| '{' should be on the previous line. |
111
|
| '{' should be on the previous line. |
113
|
| '}' should be on the same line. |
115
|
| '{' should be on the previous line. |
117
|
| Line is longer than 80 characters. |
118
|
| '+' is not preceded with whitespace. |
118
|
| '+' is not followed by whitespace. |
118
|
| '+' is not preceded with whitespace. |
118
|
| '+' is not followed by whitespace. |
118
|
| ',' is not followed by whitespace. |
118
|
| '{' should be on the previous line. |
124
|
| '{' should be on the previous line. |
126
|
| '{' should be on the previous line. |
128
|
| '}' should be on the same line. |
130
|
| '{' should be on the previous line. |
132
|
| Line is longer than 80 characters. |
133
|
| '+' is not preceded with whitespace. |
133
|
| '+' is not followed by whitespace. |
133
|
| '+' is not preceded with whitespace. |
133
|
| '+' is not followed by whitespace. |
133
|
| '+' is not preceded with whitespace. |
133
|
| '+' should be on a new line. |
133
|
org/astrogrid/ui/votable/package.html
| Error | Line |
| Missing package documentation file. | 0 |