Checkstyle Results

The following document contains the results of Checkstyle .

Summary

FilesInfosWarningsErrors
2300338

Files

FilesIWE
org/astrogrid/portal/workflow/WKF.java 0021
org/astrogrid/portal/workflow/WorkflowException.java 005
org/astrogrid/portal/workflow/impl/BasicWorkflowBuilder.java 005
org/astrogrid/portal/workflow/impl/FileApplicationRegistry.java 0011
org/astrogrid/portal/workflow/impl/FileWorkflowStore.java 0040
org/astrogrid/portal/workflow/impl/JesJobExecutionService.java 0017
org/astrogrid/portal/workflow/impl/RegistryApplicationRegistry.java 0020
org/astrogrid/portal/workflow/impl/RegistryV10ApplicationRegistry.java 0012
org/astrogrid/portal/workflow/impl/VoSpaceClientWorkflowStore.java 0039
org/astrogrid/portal/workflow/intf/ActivityKey.java 0015
org/astrogrid/portal/workflow/intf/ApplicationDescription.java 0054
org/astrogrid/portal/workflow/intf/ApplicationDescriptionSummary.java 0018
org/astrogrid/portal/workflow/intf/ApplicationRegistry.java 006
org/astrogrid/portal/workflow/intf/JobExecutionService.java 004
org/astrogrid/portal/workflow/intf/ToolValidationException.java 008
org/astrogrid/portal/workflow/intf/WorkflowBuilder.java 002
org/astrogrid/portal/workflow/intf/WorkflowInterfaceException.java 008
org/astrogrid/portal/workflow/intf/WorkflowManager.java 0018
org/astrogrid/portal/workflow/intf/WorkflowManagerFactory.java 0021
org/astrogrid/portal/workflow/intf/WorkflowStore.java 0013
org/astrogrid/portal/workflow/package.html 001

org/astrogrid/portal/workflow/WKF.java

ErrorLine
Error Class WKF should be declared as final. 24
Error Missing a Javadoc comment. 26
Error Missing a Javadoc comment. 31
Error Line contains a tab character. 34
Error Line contains a tab character. 35
Error Missing a Javadoc comment. 35
Error Line contains a tab character. 36
Error Line contains a tab character. 37
Error Line contains a tab character. 38
Error Missing a Javadoc comment. 45
Error Missing a Javadoc comment. 55
Error Missing a Javadoc comment. 61
Error Missing a Javadoc comment. 69
Error Missing a Javadoc comment. 87
Error Missing a Javadoc comment. 91
Error Missing a Javadoc comment. 96
Error Parameter key should be final. 113
Error Parameter category should be final. 113
Error Missing a Javadoc comment. 117
Error Missing a Javadoc comment. 118
Error Line contains a tab character. 130

org/astrogrid/portal/workflow/WorkflowException.java

ErrorLine
Error Missing a Javadoc comment. 33
Error Parameter message should be final. 33
Error Missing a Javadoc comment. 37
Error Parameter message should be final. 37
Error Parameter exception should be final. 37

org/astrogrid/portal/workflow/impl/BasicWorkflowBuilder.java

ErrorLine
Error Line is longer than 132 characters. 31
Error Method 'createWorkflow' is not designed for extension - needs to be abstract, final or empty. 33
Error Parameter creds should be final. 33
Error Parameter name should be final. 33
Error Parameter description should be final. 33

org/astrogrid/portal/workflow/impl/FileApplicationRegistry.java

ErrorLine
Error Missing a Javadoc comment. 39
Error Parameter regFile should be final. 43
Error Expected @param tag for 'regFile'. 43
Error Expected @throws tag for 'IOException'. 43
Error Expected @throws tag for 'CastorException'. 43
Error Missing a Javadoc comment. 55
Error Variable 'map' must be private and have accessor methods. 55
Error Method 'listApplications' is not designed for extension - needs to be abstract, final or empty. 60
Error Method 'getDescriptionFor' is not designed for extension - needs to be abstract, final or empty. 72
Error Parameter applicationName should be final. 72
Error Method 'listUIApplications' is not designed for extension - needs to be abstract, final or empty. 82

org/astrogrid/portal/workflow/impl/FileWorkflowStore.java

ErrorLine
Error Unused import - org.astrogrid.portal.workflow.intf.WorkflowStore. 16
Error Missing a Javadoc comment. 41
Error Parameter baseDir should be final. 45
Error Expected @param tag for 'baseDir'. 45
Error Missing a Javadoc comment. 52
Error Variable 'baseDir' must be private and have accessor methods. 52
Error Missing a Javadoc comment. 53
Error Parameter acc should be final. 53
Error Parameter name should be final. 53
Error Missing a Javadoc comment. 63
Error Missing a Javadoc comment. 64
Error Missing a Javadoc comment. 66
Error Parameter acc should be final. 66
Error Parameter name should be final. 66
Error Missing a Javadoc comment. 69
Error Parameter acc should be final. 69
Error Parameter name should be final. 69
Error Line is longer than 132 characters. 73
Error Method 'deleteWorkflow' is not designed for extension - needs to be abstract, final or empty. 75
Error Parameter acc should be final. 75
Error Parameter name should be final. 75
Error Method 'readQuery' is not designed for extension - needs to be abstract, final or empty. 82
Error Parameter acc should be final. 82
Error Parameter name should be final. 82
Error Method 'listQueries' is not designed for extension - needs to be abstract, final or empty. 98
Error Parameter acc should be final. 98
Error Parameter dir should be final. 103
Error Parameter name should be final. 103
Error Line is longer than 132 characters. 114
Error Method 'readWorkflow' is not designed for extension - needs to be abstract, final or empty. 116
Error Parameter acc should be final. 116
Error Parameter name should be final. 116
Error Method 'listWorkflows' is not designed for extension - needs to be abstract, final or empty. 133
Error Parameter acc should be final. 133
Error Parameter dir should be final. 138
Error Parameter name should be final. 138
Error Line is longer than 132 characters. 149
Error Method 'saveWorkflow' is not designed for extension - needs to be abstract, final or empty. 151
Error Parameter acc should be final. 151
Error Parameter workflow should be final. 151

org/astrogrid/portal/workflow/impl/JesJobExecutionService.java

ErrorLine
Error Unused import - java.net.URL. 24
Error Parameter endpoint should be final. 44
Error Expected @param tag for 'endpoint'. 44
Error Missing a Javadoc comment. 47
Error Variable 'controller' must be private and have accessor methods. 47
Error Method 'submitWorkflow' is not designed for extension - needs to be abstract, final or empty. 51
Error Parameter workflow should be final. 51
Error Method 'deleteJob' is not designed for extension - needs to be abstract, final or empty. 61
Error Parameter jobURN should be final. 61
Error Method 'cancelJob' is not designed for extension - needs to be abstract, final or empty. 71
Error Parameter jobURN should be final. 71
Error Method 'readJob' is not designed for extension - needs to be abstract, final or empty. 81
Error Parameter jobURN should be final. 81
Error Method 'readJobList' is not designed for extension - needs to be abstract, final or empty. 91
Error Parameter account should be final. 91
Error Method 'listJobs' is not designed for extension - needs to be abstract, final or empty. 103
Error Parameter account should be final. 103

org/astrogrid/portal/workflow/impl/RegistryApplicationRegistry.java

ErrorLine
Error Unused import - org.astrogrid.applications.beans.v1.InterfacesType. 14
Error Unused import - org.astrogrid.registry.beans.resource.ResourceType. 24
Error Unused import - org.astrogrid.registry.beans.resource.VODescription. 25
Error Unused import - org.apache.axis.utils.XMLUtils. 30
Error Unused import - org.w3c.dom.Node. 37
Error Unused import - java.io.File. 40
Error Unused import - java.io.FileWriter. 41
Error Line is longer than 132 characters. 47
Error Missing a Javadoc comment. 53
Error Parameter endpoint should be final. 68
Error Missing a Javadoc comment. 74
Error Variable 'service' must be private and have accessor methods. 74
Error Missing a Javadoc comment. 91
Error 'static' modifier out of order with the JLS suggestions. 91
Error Method 'listApplications' is not designed for extension - needs to be abstract, final or empty. 96
Error Missing a Javadoc comment. 96
Error Method 'listUIApplications' is not designed for extension - needs to be abstract, final or empty. 128
Error Method 'getDescriptionFor' is not designed for extension - needs to be abstract, final or empty. 178
Error Parameter applicationName should be final. 178
Error Line is longer than 132 characters. 185

org/astrogrid/portal/workflow/impl/RegistryV10ApplicationRegistry.java

ErrorLine
Error Missing a Javadoc comment. 60
Error Parameter endpoint should be final. 60
Error Missing a Javadoc comment. 68
Error Variable 'service' must be private and have accessor methods. 68
Error Missing a Javadoc comment. 70
Error 'static' modifier out of order with the JLS suggestions. 70
Error Method 'listApplications' is not designed for extension - needs to be abstract, final or empty. 78
Error Method 'getDescriptionFor' is not designed for extension - needs to be abstract, final or empty. 104
Error Parameter applicationName should be final. 104
Error Line is longer than 132 characters. 117
Error Method 'listUIApplications' is not designed for extension - needs to be abstract, final or empty. 159
Error Missing a Javadoc comment. 159

org/astrogrid/portal/workflow/impl/VoSpaceClientWorkflowStore.java

ErrorLine
Error Unused import - org.astrogrid.community.common.exception.CommunityException. 14
Error Unused import - org.astrogrid.registry.RegistryException. 21
Error Unused import - org.exolab.castor.xml.CastorException. 25
Error Unused import - java.net.URISyntaxException. 32
Error Missing a Javadoc comment. 46
Error Variable 'factory' must be private and have accessor methods. 46
Error Method 'readWorkflow' is not designed for extension - needs to be abstract, final or empty. 57
Error Parameter user should be final. 57
Error Parameter locationToReadFrom should be final. 57
Error Line is longer than 132 characters. 71
Error Method 'readWorkflow' is not designed for extension - needs to be abstract, final or empty. 73
Error Parameter userId should be final. 73
Error Parameter password should be final. 73
Error Parameter locationToReadFrom should be final. 73
Error Line is longer than 132 characters. 85
Error Method 'readWorkflow' is not designed for extension - needs to be abstract, final or empty. 87
Error Parameter fmc should be final. 87
Error Parameter locationToReadFrom should be final. 87
Error Line is longer than 132 characters. 98
Error Method 'saveWorkflow' is not designed for extension - needs to be abstract, final or empty. 100
Error Parameter user should be final. 100
Error Parameter locationToSaveTo should be final. 100
Error Parameter workflow should be final. 100
Error Must have at least one statement. 119
Error Line is longer than 132 characters. 128
Error Line is longer than 132 characters. 130
Error Method 'saveWorkflow' is not designed for extension - needs to be abstract, final or empty. 130
Error Parameter userId should be final. 130
Error Parameter password should be final. 130
Error Parameter locationToSaveTo should be final. 130
Error Parameter workflow should be final. 130
Error Must have at least one statement. 148
Error Line is longer than 132 characters. 158
Error Line is longer than 132 characters. 160
Error Method 'saveWorkflow' is not designed for extension - needs to be abstract, final or empty. 160
Error Parameter fmc should be final. 160
Error Parameter locationToSaveTo should be final. 160
Error Parameter workflow should be final. 160
Error Must have at least one statement. 178

org/astrogrid/portal/workflow/intf/ActivityKey.java

ErrorLine
Error Class ActivityKey should be declared as final. 19
Error Parameter xpath should be final. 23
Error Expected @param tag for 'xpath'. 23
Error Missing a Javadoc comment. 26
Error Line is longer than 132 characters. 33
Error Parameter root should be final. 36
Error Parameter current should be final. 36
Error Redundant throws: 'IllegalArgumentException' is unchecked exception. 36
Error Parameter root should be final. 55
Error Missing a Javadoc comment. 60
Error Parameter o should be final. 73
Error Expected @param tag for 'o'. 73
Error Avoid inline conditionals. 84
Error '31' is a magic number. 93
Error Avoid inline conditionals. 93

org/astrogrid/portal/workflow/intf/ApplicationDescription.java

ErrorLine
Error Line is longer than 132 characters. 35
Error Line is longer than 132 characters. 43
Error Parameter app should be final. 68
Error Expected @param tag for 'app'. 68
Error Parameter app should be final. 78
Error Parameter voDesc should be final. 78
Error Missing a Javadoc comment. 84
Error Missing a Javadoc comment. 85
Error Missing a Javadoc comment. 86
Error Missing a Javadoc comment. 88
Error Redundant 'final' modifier. 88
Error Parameter app should be final. 88
Error Line is longer than 132 characters. 98
Error Method 'getDefinitionForReference' is not designed for extension - needs to be abstract, final or empty. 104
Error Parameter parameterRef should be final. 104
Error Redundant throws: 'IllegalArgumentException' is unchecked exception. 104
Error Line is longer than 132 characters. 107
Error Expected an @return tag. 113
Error Method 'getReferenceForValue' is not designed for extension - needs to be abstract, final or empty. 113
Error Parameter paramVal should be final. 113
Error Expected @param tag for 'paramVal'. 113
Error Parameter intf should be final. 113
Error Expected @param tag for 'intf'. 113
Error Expected @throws tag for 'IllegalArgumentException'. 113
Error Redundant throws: 'IllegalArgumentException' is unchecked exception. 113
Error Expected an @return tag. 143
Error Method 'getDefinitionForValue' is not designed for extension - needs to be abstract, final or empty. 143
Error Parameter paramVal should be final. 143
Error Expected @param tag for 'paramVal'. 143
Error Parameter intf should be final. 143
Error Expected @param tag for 'intf'. 143
Error Expected @throws tag for 'IllegalArgumentException'. 143
Error Redundant throws: 'IllegalArgumentException' is unchecked exception. 143
Error Line is longer than 132 characters. 151
Error Method 'createValueFromDefinition' is not designed for extension - needs to be abstract, final or empty. 154
Error Parameter defn should be final. 154
Error Expected an @return tag. 173
Error Method 'createToolFromDefaultInterface' is not designed for extension - needs to be abstract, final or empty. 173
Error Method 'createToolFromInterface' is not designed for extension - needs to be abstract, final or empty. 182
Error Parameter intf should be final. 182
Error Redundant throws: 'IllegalArgumentException' is unchecked exception. 182
Error Line is longer than 132 characters. 212
Error Method 'validate' is not designed for extension - needs to be abstract, final or empty. 214
Error Parameter t should be final. 214
Error Expected @param tag for 't'. 214
Error Expected @throws tag for 'ToolValidationException'. 214
Error Missing a Javadoc comment. 246
Error Parameter reference should be final. 246
Error Parameter searchRoot should be final. 246
Error Avoid inline conditionals. 259
Error Method 'getInterfaces' is not designed for extension - needs to be abstract, final or empty. 273
Error Method 'getName' is not designed for extension - needs to be abstract, final or empty. 280
Error Method 'getParameters' is not designed for extension - needs to be abstract, final or empty. 287
Error Method 'getOriginalVODescription' is not designed for extension - needs to be abstract, final or empty. 297

org/astrogrid/portal/workflow/intf/ApplicationDescriptionSummary.java

ErrorLine
Error Parameter name should be final. 24
Error Expected @param tag for 'name'. 24
Error Parameter uiName should be final. 24
Error Expected @param tag for 'uiName'. 24
Error Parameter interfaceNames should be final. 24
Error Expected @param tag for 'interfaceNames'. 24
Error Missing a Javadoc comment. 30
Error Variable 'name' must be private and have accessor methods. 30
Error Missing a Javadoc comment. 31
Error Variable 'uiName' must be private and have accessor methods. 31
Error Missing a Javadoc comment. 32
Error Variable 'interfaceNames' must be private and have accessor methods. 32
Error Expected an @return tag. 35
Error Method 'getName' is not designed for extension - needs to be abstract, final or empty. 35
Error Expected an @return tag. 40
Error Method 'getUIName' is not designed for extension - needs to be abstract, final or empty. 40
Error Expected an @return tag. 44
Error Method 'getInterfaceNames' is not designed for extension - needs to be abstract, final or empty. 44

org/astrogrid/portal/workflow/intf/ApplicationRegistry.java

ErrorLine
Error Expected an @return tag. 23
Error Expected @throws tag for 'WorkflowInterfaceException'. 23
Error Unused @throws tag for 'WorkflowtInterfaceException'. 29
Error Expected @throws tag for 'WorkflowInterfaceException'. 31
Error Expected an @return tag. 34
Error Expected @throws tag for 'WorkflowInterfaceException'. 34

org/astrogrid/portal/workflow/intf/JobExecutionService.java

ErrorLine
Error Expected @throws tag for 'WorkflowInterfaceException'. 37
Error Expected @throws tag for 'WorkflowInterfaceException'. 43
Error Expected @throws tag for 'WorkflowInterfaceException'. 58
Error Expected @throws tag for 'WorkflowInterfaceException'. 66

org/astrogrid/portal/workflow/intf/ToolValidationException.java

ErrorLine
Error Parameter message should be final. 23
Error Expected @param tag for 'message'. 23
Error Parameter cause should be final. 29
Error Expected @param tag for 'cause'. 29
Error Parameter message should be final. 36
Error Expected @param tag for 'message'. 36
Error Parameter cause should be final. 36
Error Expected @param tag for 'cause'. 36

org/astrogrid/portal/workflow/intf/WorkflowBuilder.java

ErrorLine
Error Line is longer than 132 characters. 24
Error Expected @throws tag for 'WorkflowInterfaceException'. 29

org/astrogrid/portal/workflow/intf/WorkflowInterfaceException.java

ErrorLine
Error Parameter message should be final. 27
Error Expected @param tag for 'message'. 27
Error Parameter cause should be final. 33
Error Expected @param tag for 'cause'. 33
Error Parameter message should be final. 40
Error Expected @param tag for 'message'. 40
Error Parameter cause should be final. 40
Error Expected @param tag for 'cause'. 40

org/astrogrid/portal/workflow/intf/WorkflowManager.java

ErrorLine
Error Line is longer than 132 characters. 16
Error Missing a Javadoc comment. 23
Error Parameter builder should be final. 23
Error Parameter store should be final. 23
Error Parameter reg should be final. 23
Error Parameter jes should be final. 23
Error Missing a Javadoc comment. 31
Error Missing a Javadoc comment. 32
Error Missing a Javadoc comment. 33
Error Missing a Javadoc comment. 34
Error Expected an @return tag. 37
Error Method 'getWorkflowBuilder' is not designed for extension - needs to be abstract, final or empty. 37
Error Expected an @return tag. 41
Error Method 'getWorkflowStore' is not designed for extension - needs to be abstract, final or empty. 41
Error Expected an @return tag. 45
Error Method 'getToolRegistry' is not designed for extension - needs to be abstract, final or empty. 45
Error Expected an @return tag. 49
Error Method 'getJobExecutionService' is not designed for extension - needs to be abstract, final or empty. 49

org/astrogrid/portal/workflow/intf/WorkflowManagerFactory.java

ErrorLine
Error Line is longer than 132 characters. 31
Error Missing a Javadoc comment. 52
Error Parameter conf should be final. 61
Error Expected @param tag for 'conf'. 61
Error Missing a Javadoc comment. 64
Error Expected an @return tag. 67
Error Method 'getManager' is not designed for extension - needs to be abstract, final or empty. 67
Error Expected @throws tag for 'WorkflowInterfaceException'. 67
Error Missing a Javadoc comment. 75
Error Line is longer than 132 characters. 88
Error Missing a Javadoc comment. 88
Error Expected an @return tag. 95
Error Expected @throws tag for 'WorkflowInterfaceException'. 95
Error Expected an @return tag. 111
Error Expected an @return tag. 125
Error Expected @throws tag for 'Exception'. 125
Error Redundant throws: 'Exception' is unchecked exception. 125
Error Expected an @return tag. 147
Error Expected an @return tag. 173
Error Expected @throws tag for 'Exception'. 173
Error Redundant throws: 'Exception' is unchecked exception. 173

org/astrogrid/portal/workflow/intf/WorkflowStore.java

ErrorLine
Error Unused import - org.astrogrid.community.beans.v1.Account. 14
Error Expected @throws tag for 'WorkflowInterfaceException'. 73
Error Unused @param tag for 'authenticated'. 78
Error Expected @param tag for 'fileManagerClient'. 82
Error Expected @param tag for 'locationToReadFrom'. 82
Error Expected @throws tag for 'WorkflowInterfaceException'. 82
Error Expected @throws tag for 'WorkflowInterfaceException'. 103
Error Expected @throws tag for 'WorkflowInterfaceException'. 114
Error Unused @param tag for 'authenticated'. 118
Error Expected an @return tag. 123
Error Line is longer than 132 characters. 123
Error Expected @param tag for 'fileManagerClient'. 123
Error Expected @throws tag for 'WorkflowInterfaceException'. 123

org/astrogrid/portal/workflow/package.html

ErrorLine
Error Missing package documentation file.0